Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: PRESUBMIT.py

Issue 2911153002: Allow use of ScopedAllowIO in browser tests (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 0a9282f11a120099cc8c8a1337dfa13742fd8cff..2752765e0559fb1c5146240bb83945a803289533 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -191,26 +191,22 @@ _BANNED_CPP_FUNCTIONS = (
(
'ScopedAllowIO',
(
- 'New code should not use ScopedAllowIO. Post a task to the blocking',
- 'pool or the FILE thread instead.',
+ 'New production code should not use ScopedAllowIO (using it in',
+ 'browser tests is fine). Post a task to the blocking pool or the',
+ 'FILE thread instead.',
),
True,
(
+ r"^.*browser(|_)test[a-z_]*\.cc$",
r"^base[\\\/]memory[\\\/]shared_memory_posix\.cc$",
r"^base[\\\/]process[\\\/]internal_aix\.cc$",
r"^base[\\\/]process[\\\/]process_linux\.cc$",
r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$",
r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_recorder\.cc$",
r"^chrome[\\\/]browser[\\\/]lifetime[\\\/]application_lifetime\.cc$",
- r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]"
- "customization_document_browsertest\.cc$",
- r"^chrome[\\\/]test[\\\/]media_router[\\\/]" +
- r"media_router_integration_browsertest\.cc$",
- r"^chrome[\\\/]test[\\\/]ppapi[\\\/]ppapi_filechooser_browsertest\.cc$",
r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$",
r"^content[\\\/]shell[\\\/]browser[\\\/]layout_test[\\\/]" +
r"test_info_extractor\.cc$",
- r"^content[\\\/].*browser(|_)test[a-zA-Z_]*\.cc$",
r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$",
r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$",
r"^content[\\\/]test[\\\/]ppapi[\\\/]ppapi_test\.cc$",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698