| OLD | NEW |
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into depot_tools. | 8 for more details about the presubmit API built into depot_tools. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 184 True, | 184 True, |
| 185 ( | 185 ( |
| 186 r"^ui[\\\/]gl[\\\/].*\.cc$", | 186 r"^ui[\\\/]gl[\\\/].*\.cc$", |
| 187 r"^media[\\\/]gpu[\\\/].*\.cc$", | 187 r"^media[\\\/]gpu[\\\/].*\.cc$", |
| 188 r"^gpu[\\\/].*\.cc$", | 188 r"^gpu[\\\/].*\.cc$", |
| 189 ), | 189 ), |
| 190 ), | 190 ), |
| 191 ( | 191 ( |
| 192 'ScopedAllowIO', | 192 'ScopedAllowIO', |
| 193 ( | 193 ( |
| 194 'New code should not use ScopedAllowIO. Post a task to the blocking', | 194 'New production code should not use ScopedAllowIO (using it in', |
| 195 'pool or the FILE thread instead.', | 195 'browser tests is fine). Post a task to the blocking pool or the', |
| 196 'FILE thread instead.', |
| 196 ), | 197 ), |
| 197 True, | 198 True, |
| 198 ( | 199 ( |
| 200 r"^.*browser(|_)test[a-z_]*\.cc$", |
| 199 r"^base[\\\/]memory[\\\/]shared_memory_posix\.cc$", | 201 r"^base[\\\/]memory[\\\/]shared_memory_posix\.cc$", |
| 200 r"^base[\\\/]process[\\\/]internal_aix\.cc$", | 202 r"^base[\\\/]process[\\\/]internal_aix\.cc$", |
| 201 r"^base[\\\/]process[\\\/]process_linux\.cc$", | 203 r"^base[\\\/]process[\\\/]process_linux\.cc$", |
| 202 r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$", | 204 r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$", |
| 203 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_recorder\.cc$", | 205 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_recorder\.cc$", |
| 204 r"^chrome[\\\/]browser[\\\/]lifetime[\\\/]application_lifetime\.cc$", | 206 r"^chrome[\\\/]browser[\\\/]lifetime[\\\/]application_lifetime\.cc$", |
| 205 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]" | |
| 206 "customization_document_browsertest\.cc$", | |
| 207 r"^chrome[\\\/]test[\\\/]media_router[\\\/]" + | |
| 208 r"media_router_integration_browsertest\.cc$", | |
| 209 r"^chrome[\\\/]test[\\\/]ppapi[\\\/]ppapi_filechooser_browsertest\.cc$", | |
| 210 r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$", | 207 r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$", |
| 211 r"^content[\\\/]shell[\\\/]browser[\\\/]layout_test[\\\/]" + | 208 r"^content[\\\/]shell[\\\/]browser[\\\/]layout_test[\\\/]" + |
| 212 r"test_info_extractor\.cc$", | 209 r"test_info_extractor\.cc$", |
| 213 r"^content[\\\/].*browser(|_)test[a-zA-Z_]*\.cc$", | |
| 214 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$", | 210 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$", |
| 215 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$", | 211 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$", |
| 216 r"^content[\\\/]test[\\\/]ppapi[\\\/]ppapi_test\.cc$", | 212 r"^content[\\\/]test[\\\/]ppapi[\\\/]ppapi_test\.cc$", |
| 217 r"^media[\\\/]cast[\\\/]test[\\\/]utility[\\\/]" + | 213 r"^media[\\\/]cast[\\\/]test[\\\/]utility[\\\/]" + |
| 218 r"standalone_cast_environment\.cc$", | 214 r"standalone_cast_environment\.cc$", |
| 219 r"^mojo[\\\/]edk[\\\/]embedder[\\\/]" + | 215 r"^mojo[\\\/]edk[\\\/]embedder[\\\/]" + |
| 220 r"simple_platform_shared_buffer_posix\.cc$", | 216 r"simple_platform_shared_buffer_posix\.cc$", |
| 221 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$", | 217 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$", |
| 222 r"^net[\\\/]cert[\\\/]test_root_certs\.cc$", | 218 r"^net[\\\/]cert[\\\/]test_root_certs\.cc$", |
| 223 r"^net[\\\/]test[\\\/]embedded_test_server[\\\/]" + | 219 r"^net[\\\/]test[\\\/]embedded_test_server[\\\/]" + |
| (...skipping 2294 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 2518 output_api, | 2514 output_api, |
| 2519 json_url='http://chromium-status.appspot.com/current?format=json')) | 2515 json_url='http://chromium-status.appspot.com/current?format=json')) |
| 2520 | 2516 |
| 2521 results.extend( | 2517 results.extend( |
| 2522 input_api.canned_checks.CheckPatchFormatted(input_api, output_api)) | 2518 input_api.canned_checks.CheckPatchFormatted(input_api, output_api)) |
| 2523 results.extend(input_api.canned_checks.CheckChangeHasBugField( | 2519 results.extend(input_api.canned_checks.CheckChangeHasBugField( |
| 2524 input_api, output_api)) | 2520 input_api, output_api)) |
| 2525 results.extend(input_api.canned_checks.CheckChangeHasDescription( | 2521 results.extend(input_api.canned_checks.CheckChangeHasDescription( |
| 2526 input_api, output_api)) | 2522 input_api, output_api)) |
| 2527 return results | 2523 return results |
| OLD | NEW |