Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3588)

Unified Diff: chrome/browser/ssl/common_name_mismatch_handler.h

Issue 2911123002: Replace deprecated base::NonThreadSafe in chrome/browser/ssl in favor of SequenceChecker. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ssl/common_name_mismatch_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/common_name_mismatch_handler.h
diff --git a/chrome/browser/ssl/common_name_mismatch_handler.h b/chrome/browser/ssl/common_name_mismatch_handler.h
index 5d362266c9d224a2e765605d586cdbe0059341d1..d79f57ee1c6ea3a1472e8ac4066dc02d051b34a0 100644
--- a/chrome/browser/ssl/common_name_mismatch_handler.h
+++ b/chrome/browser/ssl/common_name_mismatch_handler.h
@@ -10,7 +10,7 @@
#include "base/callback.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
-#include "base/threading/non_thread_safe.h"
+#include "base/sequence_checker.h"
#include "base/time/time.h"
#include "net/url_request/url_fetcher.h"
#include "net/url_request/url_fetcher_delegate.h"
@@ -24,8 +24,7 @@ class URLFetcher;
// This class handles errors due to common name mismatches
// (|ERR_CERT_COMMON_NAME_INVALID|) and helps remediate them by suggesting
// alternative URLs that may be what the user intended to load.
-class CommonNameMismatchHandler : public net::URLFetcherDelegate,
- public base::NonThreadSafe {
+class CommonNameMismatchHandler : public net::URLFetcherDelegate {
public:
enum SuggestedUrlCheckResult {
// The request succeeds with good response code i.e. URL exists and its
@@ -86,6 +85,8 @@ class CommonNameMismatchHandler : public net::URLFetcherDelegate,
CheckUrlCallback check_url_callback_;
std::unique_ptr<net::URLFetcher> url_fetcher_;
+ SEQUENCE_CHECKER(sequence_checker_);
+
DISALLOW_COPY_AND_ASSIGN(CommonNameMismatchHandler);
};
« no previous file with comments | « no previous file | chrome/browser/ssl/common_name_mismatch_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698