Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2887)

Unified Diff: chrome/browser/ssl/common_name_mismatch_handler.cc

Issue 2911123002: Replace deprecated base::NonThreadSafe in chrome/browser/ssl in favor of SequenceChecker. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ssl/common_name_mismatch_handler.h ('k') | chrome/browser/ssl/ssl_error_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/common_name_mismatch_handler.cc
diff --git a/chrome/browser/ssl/common_name_mismatch_handler.cc b/chrome/browser/ssl/common_name_mismatch_handler.cc
index 9a7c9f3ea23f767083e9b560594da3e0a26ec5f1..38ad835efc517519ddc68e8044bc5682acec13b1 100644
--- a/chrome/browser/ssl/common_name_mismatch_handler.cc
+++ b/chrome/browser/ssl/common_name_mismatch_handler.cc
@@ -19,7 +19,9 @@ CommonNameMismatchHandler::CommonNameMismatchHandler(
const scoped_refptr<net::URLRequestContextGetter>& request_context)
: request_url_(request_url), request_context_(request_context) {}
-CommonNameMismatchHandler::~CommonNameMismatchHandler() {}
+CommonNameMismatchHandler::~CommonNameMismatchHandler() {
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
+}
// static
CommonNameMismatchHandler::TestingState
@@ -32,7 +34,7 @@ void CommonNameMismatchHandler::CheckSuggestedUrl(
if (testing_state_ == IGNORE_REQUESTS_FOR_TESTING)
return;
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
DCHECK(!IsCheckingSuggestedUrl());
DCHECK(check_url_callback_.is_null());
@@ -105,7 +107,7 @@ void CommonNameMismatchHandler::Cancel() {
void CommonNameMismatchHandler::OnURLFetchComplete(
const net::URLFetcher* source) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
DCHECK(IsCheckingSuggestedUrl());
DCHECK_EQ(url_fetcher_.get(), source);
DCHECK(!check_url_callback_.is_null());
« no previous file with comments | « chrome/browser/ssl/common_name_mismatch_handler.h ('k') | chrome/browser/ssl/ssl_error_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698