Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Issue 2911113003: Replace deprecated base::NonThreadSafe in media/gpu in favor of SequenceChecker. (Closed)

Created:
3 years, 6 months ago by gab
Modified:
3 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace deprecated base::NonThreadSafe in media/gpu in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=posciak@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2911113003 Cr-Commit-Position: refs/heads/master@{#476429} Committed: https://chromium.googlesource.com/chromium/src/+/eda899c5bbc75f81b298fc206da835b9884bde2e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -62 lines) Patch
M media/gpu/ipc/client/gpu_jpeg_decode_accelerator_host.h View 3 chunks +4 lines, -3 lines 0 comments Download
M media/gpu/ipc/client/gpu_jpeg_decode_accelerator_host.cc View 7 chunks +9 lines, -8 lines 0 comments Download
M media/gpu/ipc/client/gpu_video_decode_accelerator_host.h View 3 chunks +5 lines, -3 lines 0 comments Download
M media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc View 16 chunks +21 lines, -21 lines 0 comments Download
M media/gpu/ipc/client/gpu_video_encode_accelerator_host.h View 3 chunks +4 lines, -3 lines 0 comments Download
M media/gpu/ipc/client/gpu_video_encode_accelerator_host.cc View 14 chunks +14 lines, -14 lines 0 comments Download
M media/gpu/ipc/service/gpu_jpeg_decode_accelerator.h View 3 chunks +3 lines, -2 lines 0 comments Download
M media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M media/gpu/vaapi_picture.h View 3 chunks +4 lines, -2 lines 0 comments Download
M media/gpu/vaapi_picture.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
gab
Hi, this is an automated change made by https://crbug.com/676387#c8 and sharded across directories for OWNERS. ...
3 years, 6 months ago (2017-05-30 02:46:06 UTC) #3
gab
friendly ping
3 years, 6 months ago (2017-05-31 18:09:29 UTC) #7
gab
+dalecurtis per lack of response from posciak and inability to ping per timezones Please CQ ...
3 years, 6 months ago (2017-06-01 18:37:41 UTC) #9
DaleCurtis
lgtm
3 years, 6 months ago (2017-06-01 18:54:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911113003/1
3 years, 6 months ago (2017-06-01 18:55:44 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 20:54:18 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eda899c5bbc75f81b298fc206da8...

Powered by Google App Engine
This is Rietveld 408576698