Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2911093002: Worklet: Move loader client impl from ThreadedWorklet to ThreadedWorkletMessagingProxy

Created:
3 years, 6 months ago by nhiroki
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, shimazu+worker_chromium.org, haraken, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Worklet: Move loader client impl from ThreadedWorklet to ThreadedWorkletMessagingProxy This is an initial step to merge MainThreadWorklet and ThreadedWorklet into Worklet. In the current implementation, ThreadedWorklet implements the loader client for classic script loading. That's blocking the merge effort. This CL moves the client implementation from ThreadedWorklet to ThreadedWorkletMessagingProxy as LoaderClient and reduces differences between MainThreadWorklet and ThreadedWorklet. DesignDoc: https://docs.google.com/document/d/1cgLcrua7H_7x_o5GlzYrAi2qt-TqTzgtOeixFAugR6g/edit?usp=sharing BUG=727194

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Messages

Total messages: 7 (7 generated)
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-05-30 01:31:24 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911093002/1
3 years, 6 months ago (2017-05-30 01:31:35 UTC) #2
nhiroki
Description was changed from ========== Worklet: Move script loading code from ThreadedWorklet to ThreadedWorkletMessagingProxy This ...
3 years, 6 months ago (2017-05-30 01:32:54 UTC) #3
nhiroki
Description was changed from ========== Worklet: Move loader client impl from ThreadedWorklet to ThreadedWorkletMessagingProxy This ...
3 years, 6 months ago (2017-05-30 01:33:04 UTC) #4
nhiroki
Description was changed from ========== Worklet: Move loader client impl from ThreadedWorklet to ThreadedWorkletMessagingProxy This ...
3 years, 6 months ago (2017-05-30 01:33:36 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-05-30 04:02:45 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 04:02:47 UTC) #7
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698