Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2911073002: Upstream service wrkr "HTTP to HTTPS" tests to WPT (Closed)

Created:
3 years, 6 months ago by mike3
Modified:
3 years, 6 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, blink-reviews-w3ctests_chromium.org, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream service wrkr "HTTP to HTTPS" tests to WPT **http-to-https-redirect-and-register** The Web Platform Tests project's infrastructure can only provide secure contexts through the use of the HTTPS protocol. This restriction precludes the strategy used by this test because an HTTPS-origin page cannot load an HTTP-origin iframe. Introduce a related test that may run in the WPT infrastructure: one that creates browsing contexts via `window.open`. Update the surrounding logic to accomodate this alteration. Additionally, update URLs to suitable values for the WPT project, using the `base_path` utility function as per convention there. Because the new version differs substantially, the original version cannot be removed without decreasing test coverage. Persist the original version of the test within the Chromium project, and document the rational for doing so. Update both versions to include "use strict" directives for all script bodies and to avoid including unnecessary script resources. BUG=688116, 522900 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2911073002 Cr-Commit-Position: refs/heads/master@{#475538} Committed: https://chromium.googlesource.com/chromium/src/+/b72cc4fb1f44b3c5944962b7984850cba88188c7

Patch Set 1 #

Messages

Total messages: 10 (5 generated)
mike3
Hi Matt, I'm taking a cue from https://codereview.chromium.org/2869093002/ and persisting Chromium "iframe" version just in ...
3 years, 6 months ago (2017-05-29 20:48:53 UTC) #1
falken
lgtm. Thanks for thinking to persist the Chromium test. I haven't been consistent about it, ...
3 years, 6 months ago (2017-05-30 01:17:57 UTC) #3
mike3
On 2017/05/30 01:17:57, falken wrote: > lgtm. Thanks for thinking to persist the Chromium test. ...
3 years, 6 months ago (2017-05-30 14:18:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911073002/1
3 years, 6 months ago (2017-05-30 14:18:31 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 15:45:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b72cc4fb1f44b3c5944962b79848...

Powered by Google App Engine
This is Rietveld 408576698