Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: chromeos/network/network_configuration_handler_unittest.cc

Issue 2911033002: Remove raw base::DictionaryValue::Set (Closed)
Patch Set: Proper Windows Fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/fake_shill_service_client.cc ('k') | chromeos/network/onc/onc_validator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/network_configuration_handler_unittest.cc
diff --git a/chromeos/network/network_configuration_handler_unittest.cc b/chromeos/network/network_configuration_handler_unittest.cc
index 976da8ee06580130ebd65743421fea35b8be2a97..2549a20fa57119dbb2433a68beec137ea4ccb097 100644
--- a/chromeos/network/network_configuration_handler_unittest.cc
+++ b/chromeos/network/network_configuration_handler_unittest.cc
@@ -340,7 +340,7 @@ TEST_F(NetworkConfigurationHandlerTest, GetProperties) {
std::unique_ptr<base::Value> networkNameValue(new base::Value(networkName));
base::DictionaryValue value;
- value.Set(key, new base::Value(networkName));
+ value.SetString(key, networkName);
dictionary_value_result_ = &value;
EXPECT_CALL(*mock_service_client_,
SetProperty(dbus::ObjectPath(service_path), key,
@@ -404,7 +404,7 @@ TEST_F(NetworkConfigurationHandlerTest, SetProperties) {
std::unique_ptr<base::Value> networkNameValue(new base::Value(networkName));
base::DictionaryValue value;
- value.Set(key, new base::Value(networkName));
+ value.SetString(key, networkName);
dictionary_value_result_ = &value;
EXPECT_CALL(*mock_service_client_, SetProperties(_, _, _, _))
.WillOnce(
@@ -423,7 +423,7 @@ TEST_F(NetworkConfigurationHandlerTest, ClearProperties) {
// First set up a value to clear.
base::DictionaryValue value;
- value.Set(key, new base::Value(networkName));
+ value.SetString(key, networkName);
dictionary_value_result_ = &value;
EXPECT_CALL(*mock_service_client_, SetProperties(_, _, _, _))
.WillOnce(
@@ -453,7 +453,7 @@ TEST_F(NetworkConfigurationHandlerTest, ClearPropertiesError) {
// First set up a value to clear.
base::DictionaryValue value;
- value.Set(key, new base::Value(networkName));
+ value.SetString(key, networkName);
dictionary_value_result_ = &value;
EXPECT_CALL(*mock_service_client_, SetProperties(_, _, _, _))
.WillOnce(
« no previous file with comments | « chromeos/dbus/fake_shill_service_client.cc ('k') | chromeos/network/onc/onc_validator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698