Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: chromeos/dbus/fake_shill_service_client.cc

Issue 2911033002: Remove raw base::DictionaryValue::Set (Closed)
Patch Set: Proper Windows Fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/browser/cast_net_log.cc ('k') | chromeos/network/network_configuration_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/fake_shill_service_client.cc
diff --git a/chromeos/dbus/fake_shill_service_client.cc b/chromeos/dbus/fake_shill_service_client.cc
index 7075c383f3ed7e5c86ca4ea2d168067b3690cfea..363b1c7a7a5b02a8d7e6598cbd6dabeb026a8e97 100644
--- a/chromeos/dbus/fake_shill_service_client.cc
+++ b/chromeos/dbus/fake_shill_service_client.cc
@@ -534,8 +534,8 @@ base::DictionaryValue* FakeShillServiceClient::GetModifiableServiceProperties(
if (!stub_services_.GetDictionaryWithoutPathExpansion(service_path,
&properties) &&
create_if_missing) {
- properties = new base::DictionaryValue;
- stub_services_.Set(service_path, properties);
+ properties = stub_services_.SetDictionary(
+ service_path, base::MakeUnique<base::DictionaryValue>());
}
return properties;
}
« no previous file with comments | « chromecast/browser/cast_net_log.cc ('k') | chromeos/network/network_configuration_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698