chrome/browser/win/enumerate_modules_model.h - Issue 2911033002: Remove raw base::DictionaryValue::Set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/win/enumerate_modules_model.h

Issue 2911033002: Remove raw base::DictionaryValue::Set (Closed)

Patch Set: Proper Windows Fix Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/win/enumerate_modules_model.h

diff --git a/chrome/browser/win/enumerate_modules_model.h b/chrome/browser/win/enumerate_modules_model.h

index 9a212bd45ace0a7620957c686f9ea7d7d8e5c4da..7be732ea3b9cf7ac7804593782724040e8e80ad7 100644

--- a/chrome/browser/win/enumerate_modules_model.h

+++ b/chrome/browser/win/enumerate_modules_model.h

@@ -302,7 +302,7 @@ class EnumerateModulesModel {

void ScanNow(bool background_mode);

// Gets the whole module list as a ListValue.

- base::ListValue* GetModuleList();

+ std::unique_ptr<base::ListValue> GetModuleList();

// Returns the site to which the user should be taken when the conflict bubble

// or app menu item is clicked. For now this is simply chrome://conflicts,