Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: chrome/browser/win/enumerate_modules_model.cc

Issue 2911033002: Remove raw base::DictionaryValue::Set (Closed)
Patch Set: Proper Windows Fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/win/enumerate_modules_model.h ('k') | chrome/test/chromedriver/performance_logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/win/enumerate_modules_model.cc
diff --git a/chrome/browser/win/enumerate_modules_model.cc b/chrome/browser/win/enumerate_modules_model.cc
index f47f779bf7b52c2e9d55716762d1ef662349311b..d466e28dc03b96791cdc9c2c8724ee9b3bb87c54 100644
--- a/chrome/browser/win/enumerate_modules_model.cc
+++ b/chrome/browser/win/enumerate_modules_model.cc
@@ -589,7 +589,7 @@ void EnumerateModulesModel::ScanNow(bool background_mode) {
module_enumerator_->ScanNow(&enumerated_modules_);
}
-base::ListValue* EnumerateModulesModel::GetModuleList() {
+std::unique_ptr<base::ListValue> EnumerateModulesModel::GetModuleList() {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
// If a |module_enumerator_| is still around then scanning has not yet
@@ -600,7 +600,7 @@ base::ListValue* EnumerateModulesModel::GetModuleList() {
if (enumerated_modules_.empty())
return nullptr;
- base::ListValue* list = new base::ListValue();
+ auto list = base::MakeUnique<base::ListValue>();
for (ModuleEnumerator::ModulesVector::const_iterator module =
enumerated_modules_.begin();
« no previous file with comments | « chrome/browser/win/enumerate_modules_model.h ('k') | chrome/test/chromedriver/performance_logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698