Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 291103003: Font with half-width feature, font is under Open Font License 1.1 (Closed)

Created:
6 years, 7 months ago by h.joshi
Modified:
6 years, 4 months ago
CC:
blink-reviews, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Font with half-width feature, font is under Open Font License 1.1 (OFL 1.1) BUG=350404, 403211

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -0 lines) Patch
A LayoutTests/third_party/CSSOrientationTest/CSSHWOrientationTest.ttf View Binary file 0 comments Download
A LayoutTests/third_party/CSSOrientationTest/LICENSE.txt View 1 chunk +86 lines, -0 lines 0 comments Download
A LayoutTests/third_party/CSSOrientationTest/README.txt View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
h.joshi
Font file needed for https://codereview.chromium.org/263363005/ patch PTAL
6 years, 7 months ago (2014-05-20 10:04:26 UTC) #1
Dirk Pranke
On 2014/05/20 10:04:26, h.joshi wrote: > Font file needed for https://codereview.chromium.org/263363005/ patch > PTAL lgtm, ...
6 years, 7 months ago (2014-05-20 15:38:57 UTC) #2
h.joshi
Thank you, okey will merge with https://codereview.chromium.org/263363005/ Reason I made different patch was due to ...
6 years, 7 months ago (2014-05-20 17:25:05 UTC) #3
Dirk Pranke
On 2014/05/20 17:25:05, h.joshi wrote: > Thank you, okey will merge with https://codereview.chromium.org/263363005/ > Reason ...
6 years, 7 months ago (2014-05-20 18:55:58 UTC) #4
eseidel
Should this just be CQ'd?
6 years, 6 months ago (2014-05-29 00:06:08 UTC) #5
Dirk Pranke
On 2014/05/29 00:06:08, eseidel wrote: > Should this just be CQ'd? No, I think we ...
6 years, 6 months ago (2014-05-29 00:08:35 UTC) #6
h.joshi
These changes are merged in https://codereview.chromium.org/263363005/ as suggested by Dirk.
6 years, 6 months ago (2014-05-29 02:21:20 UTC) #7
h.joshi
I think we can close this as patch is merged with other patch, Pls suggest
6 years, 6 months ago (2014-05-29 02:42:53 UTC) #8
Dominik Röttsches
6 years, 6 months ago (2014-06-02 04:43:43 UTC) #9
On 2014/05/29 02:42:53, h.joshi wrote:
> I think we can close this as patch is merged with other patch, 
> Pls suggest

Yes, pls close. (Go to "Edit Issue", then tick "Closed" box.

Powered by Google App Engine
This is Rietveld 408576698