Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2911003003: Revert of Improve and fix counter texts (Closed)

Created:
3 years, 6 months ago by kjellander_chromium
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Improve and fix counter texts (patchset #2 id:20001 of https://codereview.chromium.org/2910983002/ ) Reason for revert: Breaks ios-simulator bots: https://build.chromium.org/p/chromium.mac/builders/ios-simulator/builds/17967 I'll file a bug about why analyze decided that ios_chrome_unittests could be skipped when running tryjobs when this was relanded. Original issue's description: > Improve and fix counter texts > > Change all CBD counter texts to upper case first letter. > Replace cookie counter text for consistency with other counters. > > BUG=681523 > > Review-Url: https://codereview.chromium.org/2910983002 > Cr-Original-Commit-Position: refs/heads/master@{#475344} > Committed: https://chromium.googlesource.com/chromium/src/+/818885262b08d3e4439c8ae538cec8090b5cdf2c > Review-Url: https://codereview.chromium.org/2910983002 > Cr-Commit-Position: refs/heads/master@{#475457} > Committed: https://chromium.googlesource.com/chromium/src/+/67618346e22720b39a26ff20d7b94f9b10cd5f22 TBR=msramek@chromium.org,maxwalker@chromium.org,dullweber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=681523 Review-Url: https://codereview.chromium.org/2911003003 Cr-Commit-Position: refs/heads/master@{#475496} Committed: https://chromium.googlesource.com/chromium/src/+/e34ebd44e401a8cf68522da72d9d75b9186e942c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M components/browsing_data/core/browsing_data_utils_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/browsing_data_strings.grdp View 3 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
kjellander_chromium
Created Revert of Improve and fix counter texts
3 years, 6 months ago (2017-05-30 11:33:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911003003/1
3 years, 6 months ago (2017-05-30 11:33:42 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 11:34:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e34ebd44e401a8cf68522da72d9d...

Powered by Google App Engine
This is Rietveld 408576698