Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Issue 2910983003: Replace deprecated base::NonThreadSafe in google_apis/gaia in favor of SequenceChecker. (Closed)

Created:
3 years, 6 months ago by gab
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace deprecated base::NonThreadSafe in google_apis/gaia in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=rogerta@chromium.org Review-Url: https://codereview.chromium.org/2910983003 Cr-Commit-Position: refs/heads/master@{#476406} Committed: https://chromium.googlesource.com/chromium/src/+/d19cd77fd040e15ecc2b459a6230c601a9879526

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -26 lines) Patch
M google_apis/gaia/oauth2_token_service.h View 5 chunks +6 lines, -3 lines 0 comments Download
M google_apis/gaia/oauth2_token_service.cc View 12 chunks +12 lines, -11 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_request.h View 2 chunks +4 lines, -3 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_request.cc View 8 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
gab
Hi, this is an automated change made by https://crbug.com/676387#c8 and sharded across directories for OWNERS. ...
3 years, 6 months ago (2017-05-30 02:48:07 UTC) #2
gab
friendly ping
3 years, 6 months ago (2017-05-31 18:09:34 UTC) #6
Roger Tawa OOO till Jul 10th
lgtm
3 years, 6 months ago (2017-06-01 18:47:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910983003/1
3 years, 6 months ago (2017-06-01 18:51:33 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 20:14:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d19cd77fd040e15ecc2b459a6230...

Powered by Google App Engine
This is Rietveld 408576698