Issue 291093013: Revert of Update AudioRenderer API to fire changes in BufferingState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 291093013: Revert of Update AudioRenderer API to fire changes in BufferingState. (Closed)

Created:
6 years, 7 months ago by alph

Modified:
6 years, 7 months ago

Reviewers:
acolwell GONE FROM CHROMIUM, scherkus (not reviewing)

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of Update AudioRenderer API to fire changes in BufferingState. (https://codereview.chromium.org/284763002/) Reason for revert: Broke blink tests: mediasource-redundant-seek.html mediasource-seek-during-pending-seek.html http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6/builds/28147 Original issue's description: > Update AudioRenderer API to fire changes in BufferingState. > > As a result, Pipeline now handles prerolling and underflow/rebuffering > by listening for BUFFERING_HAVE_NOTHING/ENOUGH callbacks. Preroll() is > renamed StartPlayingFrom() and no longer accepts a completion callback. > In this new model, AudioRenderers immediately enter and remain in > the "playing" state and fire buffering state callbacks to let Pipeline > know when to start/stop the clock. > > BUG=144683 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272465 TBR=acolwell@chromium.org,scherkus@chromium.org NOTREECHECKS=true NOTRY=true BUG=144683 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272501

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+395 lines, -237 lines)			Patch
M	media/base/audio_renderer.h	View	6 chunks	+13 lines, -14 lines	0 comments	Download
M	media/base/mock_filters.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/base/pipeline.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	media/base/pipeline.cc	View	12 chunks	+35 lines, -37 lines	0 comments	Download
M	media/base/pipeline_unittest.cc	View	15 chunks	+30 lines, -77 lines	0 comments	Download
M	media/filters/audio_renderer_impl.h	View	10 chunks	+29 lines, -16 lines	0 comments	Download
M	media/filters/audio_renderer_impl.cc	View	22 chunks	+91 lines, -54 lines	0 comments	Download
M	media/filters/audio_renderer_impl_unittest.cc	View	14 chunks	+191 lines, -35 lines	0 comments	Download

Total messages: 3 (0 generated)

alph

Created Revert of Update AudioRenderer API to fire changes in BufferingState.

6 years, 7 months ago (2014-05-23 12:06:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/291093013/1

6 years, 7 months ago (2014-05-23 12:06:58 UTC) #2

Message was sent while issue was closed.

Change committed as 272501