Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Issue 2910903002: MD Bookmarks: Add a metric to measure load-time performance (Closed)

Created:
3 years, 6 months ago by tsergeant
Modified:
3 years, 6 months ago
Reviewers:
calamity, benwells
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Bookmarks: Add a metric to measure load-time performance This measures page load time in the metric 'Bookmarks.ResultsRenderedTime'. Load time is measured after the page has been fully loaded and rendered. BUG=727177 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2910903002 Cr-Commit-Position: refs/heads/master@{#476916} Committed: https://chromium.googlesource.com/chromium/src/+/7167348fd337e7d77fa1dee2fdd55a4c4fe45725

Patch Set 1 #

Patch Set 2 : Reuse metric #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/resources/md_bookmarks/app.js View 1 1 chunk +6 lines, -0 lines 0 comments Download
M extensions/common/api/_api_features.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
tsergeant
PTAL. I'm not certain whether we want to reuse the existing metric or create a ...
3 years, 6 months ago (2017-05-29 04:01:34 UTC) #6
calamity
lgtm. I think it's good to keep the same metric for comparison purposes. Dealing with ...
3 years, 6 months ago (2017-05-29 05:13:47 UTC) #9
tsergeant
+benwells for _api_features.json
3 years, 6 months ago (2017-05-29 05:16:58 UTC) #11
benwells
lgtm
3 years, 6 months ago (2017-06-02 06:48:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910903002/20001
3 years, 6 months ago (2017-06-04 23:11:59 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 00:24:45 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7167348fd337e7d77fa1dee2fdd5...

Powered by Google App Engine
This is Rietveld 408576698