[System-Keyboard-Lock] Add KeycodeConverter::CodeStringToNativeKeycode() function

[System-Keyboard-Lock] Add KeycodeConverter::CodeStringToNativeKeycode() function

Native keycode is used in system keyboard lock feature to understand the input
requested keys from Javascript API.

Also for consistency, CodeToUsbKeycode() has been renamed to
CodeStringToUsbKeycode().

You will find the usage of the newly added function in,
https://codereview.chromium.org/2879033002/diff/510001/components/keyboard_lock/keyboard_lock_host.cc
function KeyboardLockHost::SetReservedKeyCodes().

For detail, please refer to the design doc at,
https://docs.google.com/document/d/1T9gJHYdA1VGZ6QHQeOu0hOacWWWJ7yNEt1VDbLju4bs/edit#heading=h.cgwemqs2j4ta

W3C Working Draft: https://garykac.github.io/system-keyboard-lock/
Intent to implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/9pauQUAvrcw/lfbG7eunCAAJ

A prototype can be found at,
https://codereview.chromium.org/2879033002

BUG=680809
Review-Url: https://codereview.chromium.org/2910873002
Cr-Commit-Position: refs/heads/master@{#476544}
Committed: https://chromium.googlesource.com/chromium/src/+/3118ff1d918e589cf32d4def65d3d40411b44428

[Hzj_jie, 2017-05-28 19:58:17]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-28 19:58:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-28 20:57:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-28 20:57:29]

Dry run: This issue passed the CQ dry run.

[Hzj_jie, 2017-05-28 20:59:43]

Description was changed from

==========
[System-Keyboard-Lock] Add KeycodeConverter::CodeStringToNativeKeycode()
function

Native keycode is used in system keyboard lock feature to understand the input
requested keys from Javascript API.

You will find the usage of the newly added function in,
https://codereview.chromium.org/2879033002/diff/510001/components/keyboard_lo...
function KeyboardLockHost::SetReservedKeyCodes().

For detail, please refer to the design doc at,
https://docs.google.com/document/d/1T9gJHYdA1VGZ6QHQeOu0hOacWWWJ7yNEt1VDbLju4...

W3C Working Draft: https://garykac.github.io/system-keyboard-lock/
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/9pauQUAvrcw/lf...

A prototype can be found at,
https://codereview.chromium.org/2879033002

BUG=680809
==========

to

==========
[System-Keyboard-Lock] Add KeycodeConverter::CodeStringToNativeKeycode()
function

Native keycode is used in system keyboard lock feature to understand the input
requested keys from Javascript API.

You will find the usage of the newly added function in,
https://codereview.chromium.org/2879033002/diff/510001/components/keyboard_lo...
function KeyboardLockHost::SetReservedKeyCodes().

For detail, please refer to the design doc at,
https://docs.google.com/document/d/1T9gJHYdA1VGZ6QHQeOu0hOacWWWJ7yNEt1VDbLju4...

W3C Working Draft: https://garykac.github.io/system-keyboard-lock/
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/9pauQUAvrcw/lf...

A prototype can be found at,
https://codereview.chromium.org/2879033002

BUG=680809
==========

[Hzj_jie, 2017-05-28 20:59:43]

zijiehe@chromium.org changed reviewers:
+ garykac@chromium.org

[garykac, 2017-06-02 01:19:38]

lgtm

https://codereview.chromium.org/2910873002/diff/1/ui/events/keycodes/dom/keyc...
File ui/events/keycodes/dom/keycode_converter.h (right):

https://codereview.chromium.org/2910873002/diff/1/ui/events/keycodes/dom/keyc...
ui/events/keycodes/dom/keycode_converter.h:105: // Convert a DOM3 Event |code|
string into a native keycode.
Use "UI Event" instead of "DOM3 Event".

"Dom3 event" is the old name for the spec.

[Hzj_jie, 2017-06-02 01:22:08]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[Hzj_jie, 2017-06-02 01:22:37]

Description was changed from

==========
[System-Keyboard-Lock] Add KeycodeConverter::CodeStringToNativeKeycode()
function

Native keycode is used in system keyboard lock feature to understand the input
requested keys from Javascript API.

You will find the usage of the newly added function in,
https://codereview.chromium.org/2879033002/diff/510001/components/keyboard_lo...
function KeyboardLockHost::SetReservedKeyCodes().

For detail, please refer to the design doc at,
https://docs.google.com/document/d/1T9gJHYdA1VGZ6QHQeOu0hOacWWWJ7yNEt1VDbLju4...

W3C Working Draft: https://garykac.github.io/system-keyboard-lock/
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/9pauQUAvrcw/lf...

A prototype can be found at,
https://codereview.chromium.org/2879033002

BUG=680809
==========

to

==========
[System-Keyboard-Lock] Add KeycodeConverter::CodeStringToNativeKeycode()
function

Native keycode is used in system keyboard lock feature to understand the input
requested keys from Javascript API.

Also for consistency, CodeToUsbKeycode() has been renamed to
CodeStringToUsbKeycode().

You will find the usage of the newly added function in,
https://codereview.chromium.org/2879033002/diff/510001/components/keyboard_lo...
function KeyboardLockHost::SetReservedKeyCodes().

For detail, please refer to the design doc at,
https://docs.google.com/document/d/1T9gJHYdA1VGZ6QHQeOu0hOacWWWJ7yNEt1VDbLju4...

W3C Working Draft: https://garykac.github.io/system-keyboard-lock/
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/9pauQUAvrcw/lf...

A prototype can be found at,
https://codereview.chromium.org/2879033002

BUG=680809
==========

[commit-bot: I haz the power, 2017-06-02 01:22:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hzj_jie, 2017-06-02 02:13:13]

https://codereview.chromium.org/2910873002/diff/1/ui/events/keycodes/dom/keyc...
File ui/events/keycodes/dom/keycode_converter.h (right):

https://codereview.chromium.org/2910873002/diff/1/ui/events/keycodes/dom/keyc...
ui/events/keycodes/dom/keycode_converter.h:105: // Convert a DOM3 Event |code|
string into a native keycode.
On 2017/06/02 01:19:38, garykac wrote:
> Use "UI Event" instead of "DOM3 Event".
> 
> "Dom3 event" is the old name for the spec.

Done.

[commit-bot: I haz the power, 2017-06-02 03:03:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 03:03:40]

Dry run: This issue passed the CQ dry run.

[Hzj_jie, 2017-06-02 03:10:27]

The CQ bit was checked by zijiehe@chromium.org

[Hzj_jie, 2017-06-02 03:10:27]

The patchset sent to the CQ was uploaded after l-g-t-m from garykac@chromium.org
Link to the patchset: https://codereview.chromium.org/2910873002/#ps20001
(title: "Resolve review comments")

[commit-bot: I haz the power, 2017-06-02 03:10:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 03:14:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496373027440210,
"parent_rev": "0eacfb43d302891d9ee769cf929f73fd656a5ce9", "commit_rev":
"3118ff1d918e589cf32d4def65d3d40411b44428"}

[commit-bot: I haz the power, 2017-06-02 03:14:58]

Description was changed from

==========
[System-Keyboard-Lock] Add KeycodeConverter::CodeStringToNativeKeycode()
function

Native keycode is used in system keyboard lock feature to understand the input
requested keys from Javascript API.

Also for consistency, CodeToUsbKeycode() has been renamed to
CodeStringToUsbKeycode().

You will find the usage of the newly added function in,
https://codereview.chromium.org/2879033002/diff/510001/components/keyboard_lo...
function KeyboardLockHost::SetReservedKeyCodes().

For detail, please refer to the design doc at,
https://docs.google.com/document/d/1T9gJHYdA1VGZ6QHQeOu0hOacWWWJ7yNEt1VDbLju4...

W3C Working Draft: https://garykac.github.io/system-keyboard-lock/
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/9pauQUAvrcw/lf...

A prototype can be found at,
https://codereview.chromium.org/2879033002

BUG=680809
==========

to

==========
[System-Keyboard-Lock] Add KeycodeConverter::CodeStringToNativeKeycode()
function

Native keycode is used in system keyboard lock feature to understand the input
requested keys from Javascript API.

Also for consistency, CodeToUsbKeycode() has been renamed to
CodeStringToUsbKeycode().

You will find the usage of the newly added function in,
https://codereview.chromium.org/2879033002/diff/510001/components/keyboard_lo...
function KeyboardLockHost::SetReservedKeyCodes().

For detail, please refer to the design doc at,
https://docs.google.com/document/d/1T9gJHYdA1VGZ6QHQeOu0hOacWWWJ7yNEt1VDbLju4...

W3C Working Draft: https://garykac.github.io/system-keyboard-lock/
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/9pauQUAvrcw/lf...

A prototype can be found at,
https://codereview.chromium.org/2879033002

BUG=680809

Review-Url: https://codereview.chromium.org/2910873002
Cr-Commit-Position: refs/heads/master@{#476544}
Committed:
https://chromium.googlesource.com/chromium/src/+/3118ff1d918e589cf32d4def65d3...
==========

[commit-bot: I haz the power, 2017-06-02 03:14:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3118ff1d918e589cf32d4def65d3...