Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4692)

Unified Diff: chrome/browser/net/predictor_browsertest.cc

Issue 2910843002: [Cleanup] Move all browsertests to use ScopedFeatureList to modify features
Patch Set: Move SFL calls to constructor Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/ukm_browsertest.cc ('k') | chrome/browser/net/predictor_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/predictor_browsertest.cc
diff --git a/chrome/browser/net/predictor_browsertest.cc b/chrome/browser/net/predictor_browsertest.cc
index fe2a9ba0584019ab850cee78c04c7aea776260ea..f0c9ab064d85ba3333c0711b1e94e31f7783fa21 100644
--- a/chrome/browser/net/predictor_browsertest.cc
+++ b/chrome/browser/net/predictor_browsertest.cc
@@ -23,6 +23,7 @@
#include "base/single_thread_task_runner.h"
#include "base/stl_util.h"
#include "base/synchronization/lock.h"
+#include "base/test/scoped_feature_list.h"
#include "base/threading/thread_task_runner_handle.h"
#include "build/build_config.h"
#include "chrome/browser/browser_process.h"
@@ -32,6 +33,7 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/common/chrome_features.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
@@ -509,6 +511,7 @@ class PredictorBrowserTest : public InProcessBrowserTest {
rule_based_resolver_proc_->AddSimulatedFailure("*.notfound");
rule_based_resolver_proc_->AddRuleWithLatency("delay.google.com",
"127.0.0.1", 1000 * 60);
+ scoped_feature_list_.InitAndEnableFeature(features::kPreconnectMore);
}
protected:
@@ -520,8 +523,6 @@ class PredictorBrowserTest : public InProcessBrowserTest {
void SetUpCommandLine(base::CommandLine* command_line) override {
command_line->AppendSwitch(
switches::kEnableExperimentalWebPlatformFeatures);
- command_line->AppendSwitchASCII(switches::kEnableFeatures,
- "PreconnectMore");
}
void SetUpOnMainThread() override {
@@ -797,6 +798,7 @@ class PredictorBrowserTest : public InProcessBrowserTest {
std::unique_ptr<net::EmbeddedTestServer> cross_site_test_server_;
std::unique_ptr<CrossSitePredictorObserver> observer_;
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
+ base::test::ScopedFeatureList scoped_feature_list_;
};
IN_PROC_BROWSER_TEST_F(PredictorBrowserTest, SingleLookupTest) {
« no previous file with comments | « chrome/browser/metrics/ukm_browsertest.cc ('k') | chrome/browser/net/predictor_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698