Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: chrome/browser/metrics/ukm_browsertest.cc

Issue 2910843002: [Cleanup] Move all browsertests to use ScopedFeatureList to modify features
Patch Set: Move SFL calls to constructor Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/ukm_browsertest.cc
diff --git a/chrome/browser/metrics/ukm_browsertest.cc b/chrome/browser/metrics/ukm_browsertest.cc
index ad1386127efe4384fdf2622b4db5986fa03d0ab6..83723eb946c0bb452aa607d0c6e27e42cc15afc0 100644
--- a/chrome/browser/metrics/ukm_browsertest.cc
+++ b/chrome/browser/metrics/ukm_browsertest.cc
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "base/test/scoped_feature_list.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/metrics/chrome_metrics_service_accessor.h"
#include "chrome/browser/profiles/profile_manager.h"
@@ -21,12 +22,8 @@ namespace metrics {
// Test fixture that provides access to some UKM internals.
class UkmBrowserTest : public SyncTest {
public:
- UkmBrowserTest() : SyncTest(SINGLE_CLIENT) {}
-
- void SetUpCommandLine(base::CommandLine* command_line) override {
- SyncTest::SetUpCommandLine(command_line);
- command_line->AppendSwitchASCII(switches::kEnableFeatures,
- ukm::kUkmFeature.name);
+ UkmBrowserTest() : SyncTest(SINGLE_CLIENT) {
+ scoped_feature_list_.InitAndEnableFeature(ukm::kUkmFeature);
}
protected:
@@ -61,6 +58,8 @@ class UkmBrowserTest : public SyncTest {
ukm::UkmService* ukm_service() {
return static_cast<ukm::UkmService*>(ukm::UkmRecorder::Get());
}
+
+ base::test::ScopedFeatureList scoped_feature_list_;
};
// Make sure that UKM is disabled while an incognito window is open.
« no previous file with comments | « chrome/browser/media/encrypted_media_supported_types_browsertest.cc ('k') | chrome/browser/net/predictor_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698