Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2910823002: Mark plugin requires restart code/resources Linux-only. (Closed)

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 6 months ago
Reviewers:
waffles, Tom Sepez
CC:
chromium-reviews, srahim+watch_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark plugin requires restart code/resources Linux-only. Review-Url: https://codereview.chromium.org/2910823002 Cr-Commit-Position: refs/heads/master@{#476477} Committed: https://chromium.googlesource.com/chromium/src/+/d6e4381835e49a1a802cb94dca33bed04e534d56

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Lei Zhang
It's more ifdefs for r424288, essentially.
3 years, 6 months ago (2017-05-30 18:41:06 UTC) #6
waffles
lgtm, thank you!
3 years, 6 months ago (2017-06-01 21:11:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910823002/1
3 years, 6 months ago (2017-06-01 21:41:45 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/453767)
3 years, 6 months ago (2017-06-01 21:55:55 UTC) #11
Lei Zhang
+tsepez for trivial IPC #ifdef.
3 years, 6 months ago (2017-06-01 22:16:07 UTC) #13
Tom Sepez
trivial LGTM
3 years, 6 months ago (2017-06-01 22:17:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910823002/1
3 years, 6 months ago (2017-06-01 22:18:54 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 23:16:41 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d6e4381835e49a1a802cb94dca33...

Powered by Google App Engine
This is Rietveld 408576698