cros: CustomFrameViewAsh avatar icon from a window prop

cros: CustomFrameViewAsh avatar icon from a window prop

- Add a kAvatarIconKey window property for avatar icon;
- CustomFrameViewAsh observes the property to update its avatar icon
  in HeaderView;
- MultiUserWindowManagerChromeOS push avatar changes when teleporting
  a window;
- Remove the deprecated SessionStateDelegate;

BUG=648964
TEST=MultiUserWindowManagerChromeOSTest.TeleportedWindowAvatarProperty

Review-Url: https://codereview.chromium.org/2910773002
Cr-Commit-Position: refs/heads/master@{#475907}
Committed: https://chromium.googlesource.com/chromium/src/+/317fdbe13422752c4a2ba6eb44027ae3fb2bd1e5

[xiyuan, 2017-05-26 22:14:02]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 22:14:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2017-05-26 22:45:23]

Description was changed from

==========
cros: CustomFrameViewAsh get avatar icon from window prop

- Add a kAvatarIconKey window property for avatar icon;
- CustomFrameViewAsh observes the property to update its avatar icon
  in HeaderView;
- MultiUserWindowManagerChromeOS push avatar changes when teleporting
  a window;
- Remove the deprecated SessionStateDelegate;

BUG=648964
==========

to

==========
cros: CustomFrameViewAsh avatar icon from a window prop

- Add a kAvatarIconKey window property for avatar icon;
- CustomFrameViewAsh observes the property to update its avatar icon
  in HeaderView;
- MultiUserWindowManagerChromeOS push avatar changes when teleporting
  a window;
- Remove the deprecated SessionStateDelegate;

BUG=648964
==========

[commit-bot: I haz the power, 2017-05-26 23:50:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 23:50:42]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2017-05-30 20:44:10]

xiyuan@chromium.org changed reviewers:
+ jamescook@chromium.org

[xiyuan, 2017-05-30 20:44:11]

Last CL to fully retire SessionStateDelegate.

[xiyuan, 2017-05-30 20:44:17]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 20:45:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-05-30 21:27:15]

Hooray! It's nice to see the delegate going away. LGTM with nits.

https://codereview.chromium.org/2910773002/diff/20001/ash/frame/custom_frame_...
File ash/frame/custom_frame_view_ash.cc (right):

https://codereview.chromium.org/2910773002/diff/20001/ash/frame/custom_frame_...
ash/frame/custom_frame_view_ash.cc:262: avatar_observer_(new
AvatarObserver(frame_, header_view_)) {
nit: base::MakeUnique

https://codereview.chromium.org/2910773002/diff/20001/ash/frame/custom_frame_...
File ash/frame/custom_frame_view_ash.h (right):

https://codereview.chromium.org/2910773002/diff/20001/ash/frame/custom_frame_...
ash/frame/custom_frame_view_ash.h:45: CustomFrameViewAsh(
nit: I think we still want "explicit" here, since there is 1 non-default
parameter.

https://codereview.chromium.org/2910773002/diff/20001/ash/frame/header_view.h
File ash/frame/header_view.h (right):

https://codereview.chromium.org/2910773002/diff/20001/ash/frame/header_view.h...
ash/frame/header_view.h:9: #include <vector>
super nit: not needed, comes from interface declaration

https://codereview.chromium.org/2910773002/diff/20001/ash/frame/header_view.h...
ash/frame/header_view.h:20: class Canvas;
super nit: not needed (comes from interface declaration)

https://codereview.chromium.org/2910773002/diff/20001/ash/mus/window_manager.h
File ash/mus/window_manager.h (right):

https://codereview.chromium.org/2910773002/diff/20001/ash/mus/window_manager....
ash/mus/window_manager.h:14: #include <unordered_map>
nit: not needed

https://codereview.chromium.org/2910773002/diff/20001/chrome/browser/ui/ash/m...
File chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
(right):

https://codereview.chromium.org/2910773002/diff/20001/chrome/browser/ui/ash/m...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:550: }
If it's not too hard, could you add test coverage for this code? It could be
something simple, like just testing that the kAvatarIconKey property exists on a
teleported window (even if the image was empty).

[xiyuan, 2017-05-30 22:43:50]

Description was changed from

==========
cros: CustomFrameViewAsh avatar icon from a window prop

- Add a kAvatarIconKey window property for avatar icon;
- CustomFrameViewAsh observes the property to update its avatar icon
  in HeaderView;
- MultiUserWindowManagerChromeOS push avatar changes when teleporting
  a window;
- Remove the deprecated SessionStateDelegate;

BUG=648964
==========

to

==========
cros: CustomFrameViewAsh avatar icon from a window prop

- Add a kAvatarIconKey window property for avatar icon;
- CustomFrameViewAsh observes the property to update its avatar icon
  in HeaderView;
- MultiUserWindowManagerChromeOS push avatar changes when teleporting
  a window;
- Remove the deprecated SessionStateDelegate;

BUG=648964
TEST=MultiUserWindowManagerChromeOSTest.TeleportedWindowAvatarProperty
==========

[xiyuan, 2017-05-30 22:44:15]

https://codereview.chromium.org/2910773002/diff/20001/ash/frame/custom_frame_...
File ash/frame/custom_frame_view_ash.cc (right):

https://codereview.chromium.org/2910773002/diff/20001/ash/frame/custom_frame_...
ash/frame/custom_frame_view_ash.cc:262: avatar_observer_(new
AvatarObserver(frame_, header_view_)) {
On 2017/05/30 21:27:15, James Cook wrote:
> nit: base::MakeUnique

Done.

https://codereview.chromium.org/2910773002/diff/20001/ash/frame/custom_frame_...
File ash/frame/custom_frame_view_ash.h (right):

https://codereview.chromium.org/2910773002/diff/20001/ash/frame/custom_frame_...
ash/frame/custom_frame_view_ash.h:45: CustomFrameViewAsh(
On 2017/05/30 21:27:15, James Cook wrote:
> nit: I think we still want "explicit" here, since there is 1 non-default
> parameter.

I see. Restored "explicit".

https://codereview.chromium.org/2910773002/diff/20001/ash/frame/header_view.h
File ash/frame/header_view.h (right):

https://codereview.chromium.org/2910773002/diff/20001/ash/frame/header_view.h...
ash/frame/header_view.h:9: #include <vector>
On 2017/05/30 21:27:15, James Cook wrote:
> super nit: not needed, comes from interface declaration

Removed. Added those because "git cl lint" complains about it.

https://codereview.chromium.org/2910773002/diff/20001/ash/frame/header_view.h...
ash/frame/header_view.h:20: class Canvas;
On 2017/05/30 21:27:15, James Cook wrote:
> super nit: not needed (comes from interface declaration)

Removed.

https://codereview.chromium.org/2910773002/diff/20001/ash/mus/window_manager.h
File ash/mus/window_manager.h (right):

https://codereview.chromium.org/2910773002/diff/20001/ash/mus/window_manager....
ash/mus/window_manager.h:14: #include <unordered_map>
On 2017/05/30 21:27:15, James Cook wrote:
> nit: not needed

Done.

https://codereview.chromium.org/2910773002/diff/20001/chrome/browser/ui/ash/m...
File chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
(right):

https://codereview.chromium.org/2910773002/diff/20001/chrome/browser/ui/ash/m...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:550: }
On 2017/05/30 21:27:15, James Cook wrote:
> If it's not too hard, could you add test coverage for this code? It could be
> something simple, like just testing that the kAvatarIconKey property exists on
a
> teleported window (even if the image was empty).

Done.

[xiyuan, 2017-05-30 22:46:42]

xiyuan@chromium.org changed reviewers:
+ sky@chromium.org

[xiyuan, 2017-05-30 22:46:43]

+sky for owner stamp on
  ui/aura/client/aura_constants.*

This adds a kAvatarIconKey window property key for an avatar icon to be display
on CustomFrameViweAsh. This way, the icon is pushed to CustomFrameViweAsh
instead of it pulling it via SessionStateDelegate.

[xiyuan, 2017-05-30 22:47:57]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 22:48:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-05-30 23:21:06]

LGTM

[commit-bot: I haz the power, 2017-05-31 00:59:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 00:59:41]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2017-05-31 14:55:08]

The CQ bit was checked by xiyuan@chromium.org

[xiyuan, 2017-05-31 14:55:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2910773002/#ps40001
(title: "add test")

[commit-bot: I haz the power, 2017-05-31 14:55:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 15:02:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496242508300600,
"parent_rev": "ccc6023cc4f97a2994a4aa753a89ad4f32b97a84", "commit_rev":
"317fdbe13422752c4a2ba6eb44027ae3fb2bd1e5"}

[commit-bot: I haz the power, 2017-05-31 15:02:16]

Description was changed from

==========
cros: CustomFrameViewAsh avatar icon from a window prop

- Add a kAvatarIconKey window property for avatar icon;
- CustomFrameViewAsh observes the property to update its avatar icon
  in HeaderView;
- MultiUserWindowManagerChromeOS push avatar changes when teleporting
  a window;
- Remove the deprecated SessionStateDelegate;

BUG=648964
TEST=MultiUserWindowManagerChromeOSTest.TeleportedWindowAvatarProperty
==========

to

==========
cros: CustomFrameViewAsh avatar icon from a window prop

- Add a kAvatarIconKey window property for avatar icon;
- CustomFrameViewAsh observes the property to update its avatar icon
  in HeaderView;
- MultiUserWindowManagerChromeOS push avatar changes when teleporting
  a window;
- Remove the deprecated SessionStateDelegate;

BUG=648964
TEST=MultiUserWindowManagerChromeOSTest.TeleportedWindowAvatarProperty

Review-Url: https://codereview.chromium.org/2910773002
Cr-Commit-Position: refs/heads/master@{#475907}
Committed:
https://chromium.googlesource.com/chromium/src/+/317fdbe13422752c4a2ba6eb4402...
==========

[commit-bot: I haz the power, 2017-05-31 15:02:19]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/317fdbe13422752c4a2ba6eb4402...