Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2910743002: Do not elevate to register Chrome for system-level Win7 installs. (Closed)

Created:
3 years, 7 months ago by grt (UTC plus 2)
Modified:
3 years, 6 months ago
Reviewers:
gab
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Do not elevate to register Chrome for system-level Win7 installs. On Windows 7, browsers must be registered with the OS in HKLM. Chrome's installer takes care of this during install/update for system-level installs. For user-level installs, however, Chrome must pop a UAC prompt to have setup.exe run at high integrity for this registration. This change suppresses the elevate-to-register codepath for system-level installs on Windows 7 since this is the installer's responsibility. This prevents over-prompting some users (see the bug for details) at the risk of not prompting users for whom Chrome truly isn't registered. If those users are running a properly updating Chrome, its registration will be repaired on the next update. If they are not running an updating Chrome, they have bigger problems. BUG=717913 R=gab@chromium.org Review-Url: https://codereview.chromium.org/2878953003 Cr-Original-Commit-Position: refs/heads/master@{#472750} Review-Url: https://codereview.chromium.org/2910743002 . Cr-Commit-Position: refs/branch-heads/3071@{#706} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/bf573c90784bf148baf921734b2f48eb660b37a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -41 lines) Patch
M chrome/installer/util/shell_util.cc View 4 chunks +48 lines, -41 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
grt (UTC plus 2)
Committed patchset #1 (id:1) manually as bf573c90784bf148baf921734b2f48eb660b37a8.
3 years, 7 months ago (2017-05-26 20:41:41 UTC) #2
gab
3 years, 6 months ago (2017-05-31 14:56:49 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698