cros: Fix potential null-deref when sleeping system on views-lock.

cros: Fix potential null-deref when sleeping system on views-lock.

BUG=719015
Review-Url: https://codereview.chromium.org/2910733002
Cr-Commit-Position: refs/heads/master@{#475194}
Committed: https://chromium.googlesource.com/chromium/src/+/7e8a1b15604183c428d3515ef46556ecd49a5eea

[jdufault, 2017-05-26 20:28:51]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 20:29:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 21:11:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 21:11:08]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-05-26 21:18:42]

Description was changed from

==========
cros: Fix null-deref when sleeping system on views-lock.

BUG=
==========

to

==========
cros: Fix null-deref when sleeping system on views-lock.

BUG=719015
==========

[jdufault, 2017-05-26 21:21:01]

Description was changed from

==========
cros: Fix null-deref when sleeping system on views-lock.

BUG=719015
==========

to

==========
cros: Fix potential null-deref when sleeping system on views-lock.

BUG=719015
==========

[jdufault, 2017-05-26 21:21:01]

jdufault@chromium.org changed reviewers:
+ derat@chromium.org

[jdufault, 2017-05-26 21:35:55]

derat@ PTAL, thanks. This can be null when not using webui-based lock screen.

[Daniel Erat, 2017-05-26 22:10:07]

lgtm

https://codereview.chromium.org/2910733002/diff/1/chrome/browser/chromeos/pow...
File chrome/browser/chromeos/power/renderer_freezer.cc (right):

https://codereview.chromium.org/2910733002/diff/1/chrome/browser/chromeos/pow...
chrome/browser/chromeos/power/renderer_freezer.cc:152: if (web_contents) {
nit: mind adding a comment here mentioning why this is null? (or TODO pointing
at a bug, if the plan is to switch to the views-based lock screen and this can
be removed later)

[jdufault, 2017-05-26 23:14:26]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2017-05-26 23:14:26]

The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org
Link to the patchset: https://codereview.chromium.org/2910733002/#ps20001
(title: "Add TODO")

[commit-bot: I haz the power, 2017-05-26 23:14:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2017-05-26 23:15:20]

https://codereview.chromium.org/2910733002/diff/1/chrome/browser/chromeos/pow...
File chrome/browser/chromeos/power/renderer_freezer.cc (right):

https://codereview.chromium.org/2910733002/diff/1/chrome/browser/chromeos/pow...
chrome/browser/chromeos/power/renderer_freezer.cc:152: if (web_contents) {
On 2017/05/26 22:10:06, Daniel Erat wrote:
> nit: mind adding a comment here mentioning why this is null? (or TODO pointing
> at a bug, if the plan is to switch to the views-based lock screen and this can
> be removed later)

Done.

[commit-bot: I haz the power, 2017-05-26 23:45:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495840466314360,
"parent_rev": "0933f4586224dd6de793b6118b763910e0a19d92", "commit_rev":
"7e8a1b15604183c428d3515ef46556ecd49a5eea"}

[commit-bot: I haz the power, 2017-05-26 23:45:25]

Description was changed from

==========
cros: Fix potential null-deref when sleeping system on views-lock.

BUG=719015
==========

to

==========
cros: Fix potential null-deref when sleeping system on views-lock.

BUG=719015

Review-Url: https://codereview.chromium.org/2910733002
Cr-Commit-Position: refs/heads/master@{#475194}
Committed:
https://chromium.googlesource.com/chromium/src/+/7e8a1b15604183c428d3515ef465...
==========

[commit-bot: I haz the power, 2017-05-26 23:45:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7e8a1b15604183c428d3515ef465...