Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 2910723002: DRProxyDelegate should source it's proxy config from configurator

Created:
3 years, 7 months ago by RyanSturm
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DRProxyDelegate should source it's proxy config from configurator Configurator contains the list of proxies to use, whereas config contains the proxies that it could use (barring enabled and holdback). BUG=726773

Patch Set 1 #

Patch Set 2 : build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc View 1 1 chunk +6 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (12 generated)
RyanSturm
The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-26 18:30:42 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910723002/1
3 years, 7 months ago (2017-05-26 18:31:15 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-26 18:37:25 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/220085) ios-simulator on ...
3 years, 7 months ago (2017-05-26 18:37:25 UTC) #4
RyanSturm
The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-26 19:27:22 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910723002/20001
3 years, 7 months ago (2017-05-26 19:27:54 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-26 19:36:19 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/377287) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 7 months ago (2017-05-26 19:36:20 UTC) #8
RyanSturm
The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-26 20:05:29 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910723002/20001
3 years, 7 months ago (2017-05-26 20:05:54 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-26 21:42:15 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 21:42:16 UTC) #12
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698