[TTS] Fix expanding selection at end of some lines

[TTS] Fix expanding selection at end of some lines

Fixes a bug where the resolved term isn't always selected in the text.
The case fixed is due to the selection including a trailing space
when at the end of a line.  It's unclear why the trailing space is
included in the selection.  We simply trim the trailing space.

BUG=726767
Review-Url: https://codereview.chromium.org/2910713002
Cr-Commit-Position: refs/heads/master@{#476506}
Committed: https://chromium.googlesource.com/chromium/src/+/08060b17bf13ffc5bd17f6d863727a2cfa834119

[Donn Denman, 2017-05-26 18:22:27]

The CQ bit was checked by donnd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 18:22:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 19:39:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 19:39:45]

Dry run: This issue passed the CQ dry run.

[Donn Denman, 2017-06-01 22:51:31]

donnd@chromium.org changed reviewers:
+ twellington@chromium.org

[Donn Denman, 2017-06-01 22:51:31]

Theresa, PTAL at this simple fix whenever convenient.

[Theresa, 2017-06-01 23:06:20]

https://codereview.chromium.org/2910713002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
(right):

https://codereview.chromium.org/2910713002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java:729:
if (currentSelection != null) currentSelection = currentSelection.trim();
Will the originalSelection ever have trailing whitespace that needs to be
trimmed?

[Donn Denman, 2017-06-01 23:20:07]

PTAL, and thanks for the review!

https://codereview.chromium.org/2910713002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
(right):

https://codereview.chromium.org/2910713002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java:729:
if (currentSelection != null) currentSelection = currentSelection.trim();
On 2017/06/01 23:06:20, Theresa wrote:
> Will the originalSelection ever have trailing whitespace that needs to be
> trimmed? 

I don't think so, but it doesn't hurt to trim the originalSelection too.  Done.

[Theresa, 2017-06-01 23:24:38]

lgtm

[Donn Denman, 2017-06-01 23:29:56]

The CQ bit was checked by donnd@chromium.org

[commit-bot: I haz the power, 2017-06-01 23:30:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 01:02:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496359796916590,
"parent_rev": "49c3b86554c09f298bd100c02c812be4aa2f0e15", "commit_rev":
"08060b17bf13ffc5bd17f6d863727a2cfa834119"}

[commit-bot: I haz the power, 2017-06-02 01:02:43]

Description was changed from

==========
[TTS] Fix expanding selection at end of some lines

Fixes a bug where the resolved term isn't always selected in the text.
The case fixed is due to the selection including a trailing space
when at the end of a line.  It's unclear why the trailing space is
included in the selection.  We simply trim the trailing space.

BUG=726767
==========

to

==========
[TTS] Fix expanding selection at end of some lines

Fixes a bug where the resolved term isn't always selected in the text.
The case fixed is due to the selection including a trailing space
when at the end of a line.  It's unclear why the trailing space is
included in the selection.  We simply trim the trailing space.

BUG=726767

Review-Url: https://codereview.chromium.org/2910713002
Cr-Commit-Position: refs/heads/master@{#476506}
Committed:
https://chromium.googlesource.com/chromium/src/+/08060b17bf13ffc5bd17f6d86372...
==========

[commit-bot: I haz the power, 2017-06-02 01:02:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/08060b17bf13ffc5bd17f6d86372...