Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2910533003: MIPS[64]: SIMD Visitors macro-ization (Closed)

Created:
3 years, 7 months ago by dusan.simicic
Modified:
3 years, 6 months ago
Reviewers:
ivica.bogosavljevic, ilija.pavlovic, miran.karic, Ilija.Pavlovic1
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS[64]: SIMD Visitors macro-ization Macro-ization of Turbofan's SIMD Visitor methods in the same way it was done for ARM and x64 architectures. BUG= Review-Url: https://codereview.chromium.org/2910533003 Cr-Commit-Position: refs/heads/master@{#45704} Committed: https://chromium.googlesource.com/v8/v8/+/a234136074366a8ab8d1c703bad1949ec5a1f033

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -935 lines) Patch
M src/compiler/mips/instruction-selector-mips.cc View 1 1 chunk +170 lines, -464 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 1 chunk +177 lines, -471 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
dusan.simicic
PTAL
3 years, 7 months ago (2017-05-26 11:57:08 UTC) #2
Ilija.Pavlovic1
lgtm
3 years, 6 months ago (2017-05-29 08:01:30 UTC) #4
ivica.bogosavljevic
lgtm
3 years, 6 months ago (2017-06-05 09:14:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910533003/20001
3 years, 6 months ago (2017-06-05 10:03:54 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 10:05:03 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/a234136074366a8ab8d1c703bad1949ec5a...

Powered by Google App Engine
This is Rietveld 408576698