Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2910513006: input: Immediately start timer for synthetic event dispatch. (Closed)

Created:
3 years, 6 months ago by sadrul
Modified:
3 years, 6 months ago
Reviewers:
dtapuska, tdresser
CC:
chromium-reviews, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

input: Immediately start timer for synthetic event dispatch. The timer to send synthesized input events during telemetry tests is currently started at begin-frame + fixed-offset. The reason for doing this is to minimize the noise in the results. However, main thread already does rAF alignment for input event dispatch, which likely means that we can change the browser to always immediately start the timer, and still not affect the noise. So do that in this CL, which simplifies the code too. BUG=725949, 722921 Review-Url: https://codereview.chromium.org/2910513006 Cr-Commit-Position: refs/heads/master@{#475692} Committed: https://chromium.googlesource.com/chromium/src/+/e437543b5a4c01773a489e26659a9b05b7d7c365

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -25 lines) Patch
M content/browser/renderer_host/input/synthetic_gesture_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_controller.cc View 2 chunks +1 line, -22 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sadrul
As I mentioned in the bug, I am curious to see what the effect this ...
3 years, 6 months ago (2017-05-29 16:22:48 UTC) #7
tdresser
LGTM. Sending an email to perf-sheriffs@chromium.org when it lands would be nice.
3 years, 6 months ago (2017-05-29 17:18:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910513006/1
3 years, 6 months ago (2017-05-30 20:32:44 UTC) #10
sadrul
On 2017/05/29 17:18:51, tdresser wrote: > LGTM. Sending an email to mailto:perf-sheriffs@chromium.org when it lands ...
3 years, 6 months ago (2017-05-30 20:36:54 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 23:39:46 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e437543b5a4c01773a489e26659a...

Powered by Google App Engine
This is Rietveld 408576698