[CRD iOS] Fix telemetry issues

remoting/ios/facade/remoting_service.mm

Index: remoting/ios/facade/remoting_service.mm
diff --git a/remoting/ios/facade/remoting_service.mm b/remoting/ios/facade/remoting_service.mm
index d4c338c554963144d1f61c5125b98e3419093463..92417ecaf80cd53fa3035ff4569cabeca672c858 100644
--- a/remoting/ios/facade/remoting_service.mm
+++ b/remoting/ios/facade/remoting_service.mm
@@ -97,8 +97,8 @@ NSString* const kUserInfo = @"kUserInfo";
             default:
               NOTREACHED();
           }
-          // TODO(nicholss): Not yet integrated: createdTime, hostVersion,
-          // kind, offlineReason. Add them as the app will need this info.
+          // TODO(nicholss): Not yet integrated: createdTime, kind,
+          // offlineReason. Add them as the app will need this info.
           HostInfo* host = [[HostInfo alloc] init];
           host.hostId =
               [NSString stringWithCString:host_info.host_id.c_str()
@@ -106,6 +106,15 @@ NSString* const kUserInfo = @"kUserInfo";
           host.hostName =
               [NSString stringWithCString:host_info.host_name.c_str()
                                  encoding:[NSString defaultCStringEncoding]];
+          host.hostOs =
+              [NSString stringWithCString:host_info.host_os.c_str()

[nicholss, 2017/05/25 21:51:47]

I did not know at the time, but there is a base chromium macro to convert std
strings to ns strings, can you update the usage here?

https://cs.chromium.org/chromium/src/base/strings/sys_string_conversions.h?ty...

I think you want to use SysUTF8ToNSString() and that replaces the entire
NSString stringWithCString blah blah.

[Yuwei, 2017/05/25 22:24:24]

Done. This is quite nice :)

+                                 encoding:[NSString defaultCStringEncoding]];
+          host.hostOsVersion =
+              [NSString stringWithCString:host_info.host_os_version.c_str()
+                                 encoding:[NSString defaultCStringEncoding]];
+          host.hostVersion =
+              [NSString stringWithCString:host_info.host_version.c_str()
+                                 encoding:[NSString defaultCStringEncoding]];
           host.jabberId =
               [NSString stringWithCString:host_info.host_jid.c_str()
                                  encoding:[NSString defaultCStringEncoding]];