Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1363)

Unified Diff: net/proxy/dhcp_proxy_script_adapter_fetcher_win.h

Issue 2910473005: Deprecate NonThreadSafe in net/ in favor of SequenceChecker/ThreadChecker. (Closed)
Patch Set: rebase on r476634 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/log/write_to_file_net_log_observer.cc ('k') | net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/dhcp_proxy_script_adapter_fetcher_win.h
diff --git a/net/proxy/dhcp_proxy_script_adapter_fetcher_win.h b/net/proxy/dhcp_proxy_script_adapter_fetcher_win.h
index 7d72537a77e065f13c776fa71309f4df9a50dc42..51a4876e0f5c1a2f8ae89065a42d9fef1e49aa51 100644
--- a/net/proxy/dhcp_proxy_script_adapter_fetcher_win.h
+++ b/net/proxy/dhcp_proxy_script_adapter_fetcher_win.h
@@ -14,7 +14,7 @@
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
#include "base/strings/string16.h"
-#include "base/threading/non_thread_safe.h"
+#include "base/threading/thread_checker.h"
#include "base/timer/timer.h"
#include "net/base/completion_callback.h"
#include "net/base/net_export.h"
@@ -32,8 +32,7 @@ class URLRequestContext;
// For a given adapter, this class takes care of first doing a DHCP lookup
// to get the PAC URL, then if there is one, trying to fetch it.
class NET_EXPORT_PRIVATE DhcpProxyScriptAdapterFetcher
- : public base::SupportsWeakPtr<DhcpProxyScriptAdapterFetcher>,
- NON_EXPORTED_BASE(public base::NonThreadSafe) {
+ : public base::SupportsWeakPtr<DhcpProxyScriptAdapterFetcher> {
public:
// |url_request_context| must outlive DhcpProxyScriptAdapterFetcher.
// |task_runner| will be used to post tasks to a thread.
@@ -185,6 +184,8 @@ class NET_EXPORT_PRIVATE DhcpProxyScriptAdapterFetcher
URLRequestContext* const url_request_context_;
+ THREAD_CHECKER(thread_checker_);
+
DISALLOW_IMPLICIT_CONSTRUCTORS(DhcpProxyScriptAdapterFetcher);
};
« no previous file with comments | « net/log/write_to_file_net_log_observer.cc ('k') | net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698