net/log/write_to_file_net_log_observer.cc - Issue 2910473005: Deprecate NonThreadSafe in net/ in favor of SequenceChecker/ThreadChecker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/log/write_to_file_net_log_observer.cc

Issue 2910473005: Deprecate NonThreadSafe in net/ in favor of SequenceChecker/ThreadChecker. (Closed)

Patch Set: rebase on r476634 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/log/write_to_file_net_log_observer.cc

diff --git a/net/log/write_to_file_net_log_observer.cc b/net/log/write_to_file_net_log_observer.cc

index 5470ebbcd44d2d880fe9b1a4d8c387ea5db9f7f2..ce23799402e00e95f998642ddb7bc1ca3e98d7c7 100644

--- a/net/log/write_to_file_net_log_observer.cc

+++ b/net/log/write_to_file_net_log_observer.cc

@@ -57,7 +57,7 @@ void WriteToFileNetLogObserver::StartObserving(

// Add events for in progress requests if a context is given.

if (url_request_context) {

- DCHECK(url_request_context->CalledOnValidThread());

+ url_request_context->AssertCalledOnValidThread();

std::set<URLRequestContext*> contexts;

contexts.insert(url_request_context);

@@ -76,7 +76,7 @@ void WriteToFileNetLogObserver::StopObserving(

// Write state of the URLRequestContext when logging stopped.

if (url_request_context) {

- DCHECK(url_request_context->CalledOnValidThread());

+ url_request_context->AssertCalledOnValidThread();

std::string json;

base::JSONWriter::Write(

« no previous file with comments | « net/log/net_log_util.cc ('k') | net/proxy/dhcp_proxy_script_adapter_fetcher_win.h » ('j') | no next file with comments »