Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1150)

Unified Diff: net/http/http_server_properties_impl.h

Issue 2910473005: Deprecate NonThreadSafe in net/ in favor of SequenceChecker/ThreadChecker. (Closed)
Patch Set: another compile nit Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_server_properties_impl.h
diff --git a/net/http/http_server_properties_impl.h b/net/http/http_server_properties_impl.h
index 598b4474e88d2ed590dd46978f44283ee610da38..91193d6b01ae7d46adb421bf868a221921a01f15 100644
--- a/net/http/http_server_properties_impl.h
+++ b/net/http/http_server_properties_impl.h
@@ -16,7 +16,7 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
-#include "base/threading/non_thread_safe.h"
+#include "base/sequence_checker.h"
#include "base/values.h"
#include "net/base/host_port_pair.h"
#include "net/base/ip_address.h"
@@ -37,9 +37,7 @@ struct AlternativeServiceHash {
};
// The implementation for setting/retrieving the HTTP server properties.
-class NET_EXPORT HttpServerPropertiesImpl
- : public HttpServerProperties,
- NON_EXPORTED_BASE(public base::NonThreadSafe) {
+class NET_EXPORT HttpServerPropertiesImpl : public HttpServerProperties {
public:
HttpServerPropertiesImpl();
~HttpServerPropertiesImpl() override;
@@ -175,6 +173,8 @@ class NET_EXPORT HttpServerPropertiesImpl
QuicServerInfoMap quic_server_info_map_;
size_t max_server_configs_stored_in_properties_;
+ SEQUENCE_CHECKER(sequence_checker_);
+
base::WeakPtrFactory<HttpServerPropertiesImpl> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(HttpServerPropertiesImpl);

Powered by Google App Engine
This is Rietveld 408576698