Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: net/http/http_server_properties_impl.cc

Issue 2910473005: Deprecate NonThreadSafe in net/ in favor of SequenceChecker/ThreadChecker. (Closed)
Patch Set: another compile nit Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_server_properties_impl.cc
diff --git a/net/http/http_server_properties_impl.cc b/net/http/http_server_properties_impl.cc
index 7cc4a3298a2f9780dfa30e4059f073ccc824d8e2..18004620603c1f6f1b45d85359878f9f129ae2a1 100644
--- a/net/http/http_server_properties_impl.cc
+++ b/net/http/http_server_properties_impl.cc
@@ -46,12 +46,13 @@ HttpServerPropertiesImpl::HttpServerPropertiesImpl()
}
HttpServerPropertiesImpl::~HttpServerPropertiesImpl() {
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
}
void HttpServerPropertiesImpl::SetSpdyServers(
std::vector<std::string>* spdy_servers,
bool support_spdy) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
if (!spdy_servers)
return;
@@ -189,7 +190,7 @@ void HttpServerPropertiesImpl::SetQuicServerInfoMap(
void HttpServerPropertiesImpl::GetSpdyServerList(
base::ListValue* spdy_server_list,
size_t max_size) const {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
DCHECK(spdy_server_list);
spdy_server_list->Clear();
size_t count = 0;
@@ -205,7 +206,7 @@ void HttpServerPropertiesImpl::GetSpdyServerList(
}
void HttpServerPropertiesImpl::Clear() {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
spdy_servers_map_.Clear();
alternative_service_map_.Clear();
canonical_host_to_origin_map_.clear();
@@ -216,7 +217,7 @@ void HttpServerPropertiesImpl::Clear() {
bool HttpServerPropertiesImpl::SupportsRequestPriority(
const url::SchemeHostPort& server) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
if (server.host().empty())
return false;
@@ -235,7 +236,7 @@ bool HttpServerPropertiesImpl::SupportsRequestPriority(
bool HttpServerPropertiesImpl::GetSupportsSpdy(
const url::SchemeHostPort& server) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
if (server.host().empty())
return false;
@@ -247,7 +248,7 @@ bool HttpServerPropertiesImpl::GetSupportsSpdy(
void HttpServerPropertiesImpl::SetSupportsSpdy(
const url::SchemeHostPort& server,
bool support_spdy) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
if (server.host().empty())
return;
@@ -263,7 +264,7 @@ void HttpServerPropertiesImpl::SetSupportsSpdy(
bool HttpServerPropertiesImpl::RequiresHTTP11(
const HostPortPair& host_port_pair) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
if (host_port_pair.host().empty())
return false;
@@ -272,7 +273,7 @@ bool HttpServerPropertiesImpl::RequiresHTTP11(
void HttpServerPropertiesImpl::SetHTTP11Required(
const HostPortPair& host_port_pair) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
if (host_port_pair.host().empty())
return;

Powered by Google App Engine
This is Rietveld 408576698