Issue 2910463002: Allow plugins to provide completions for non-dart files

Issue 2910463002: Allow plugins to provide completions for non-dart files (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson

Modified:
3 years, 7 months ago

Reviewers:
maxkim, scheglov

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -38 lines)			Patch
M	pkg/analysis_server/lib/src/domain_completion.dart	View	3 chunks	+36 lines, -35 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/completion_core.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/domain_completion_test.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/integration/completion/get_suggestions_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

Brian Wilkerson

I think this fixes the problem that was preventing completion requests from flowing to plugins ...

3 years, 7 months ago (2017-05-25 17:16:32 UTC) #2

maxkim

On 2017/05/25 17:35:40, maxkim wrote: > lgtm Forgot to add, verified that autocompletion is working ...

3 years, 7 months ago (2017-05-25 17:41:39 UTC) #5

Brian Wilkerson

3 years, 7 months ago (2017-05-25 17:53:12 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
013411c10bfa68864c2f78e5a6ff5ff221322210 (presubmit successful).