Allow plugins to provide completions for non-dart files

pkg/analysis_server/lib/src/domain_completion.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:analysis_server/protocol/protocol.dart';
 import 'package:analysis_server/protocol/protocol_generated.dart';
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/constants.dart';
@@ skipping 69 matching lines @@
     int offset = params.offset;
     AnalysisDriver driver = server.getAnalysisDriver(file);
     if (driver != null) {
       requestParams = new plugin.CompletionGetSuggestionsParams(file, offset);
       pluginFutures = server.pluginManager
           .broadcastRequest(requestParams, contextRoot: driver.contextRoot);
     }
     //
     // Compute completions generated by server.
     //
-    Iterable<CompletionContributor> newContributors =
-        server.serverPlugin.completionContributors;
     List<CompletionSuggestion> suggestions = <CompletionSuggestion>[];
+    if (request.result != null) {
+      Iterable<CompletionContributor> newContributors =
+          server.serverPlugin.completionContributors;
 
-    const COMPUTE_SUGGESTIONS_TAG = 'computeSuggestions';
-    performance.logStartTime(COMPUTE_SUGGESTIONS_TAG);
+      const COMPUTE_SUGGESTIONS_TAG = 'computeSuggestions';
+      performance.logStartTime(COMPUTE_SUGGESTIONS_TAG);
 
-    for (CompletionContributor contributor in newContributors) {
-      String contributorTag = 'computeSuggestions - ${contributor.runtimeType}';
-      performance.logStartTime(contributorTag);
-      try {
-        suggestions.addAll(await contributor.computeSuggestions(request));
-      } on AbortCompletion {
-        suggestions.clear();
-        break;
+      for (CompletionContributor contributor in newContributors) {
+        String contributorTag = 'computeSuggestions - ${contributor
+            .runtimeType}';
+        performance.logStartTime(contributorTag);
+        try {
+          suggestions.addAll(await contributor.computeSuggestions(request));
+        } on AbortCompletion {
+          suggestions.clear();
+          break;
+        }
+        performance.logElapseTime(contributorTag);
       }
-      performance.logElapseTime(contributorTag);
+      performance.logElapseTime(COMPUTE_SUGGESTIONS_TAG);
     }
-    performance.logElapseTime(COMPUTE_SUGGESTIONS_TAG);
-
     // TODO (danrubel) if request is obsolete (processAnalysisRequest returns
     // false) then send empty results
 
     //
     // Add the fixes produced by plugins to the server-generated fixes.
     //
     if (pluginFutures != null) {
       List<plugin.Response> responses = await waitForResponses(pluginFutures,
           requestParameters: requestParams);
       for (plugin.Response response in responses) {
@@ skipping 34 matching lines @@
 
   /**
    * Process a `completion.getSuggestions` request.
    */
   Future<Null> processRequest(Request request) async {
     performance = new CompletionPerformance();
 
     // extract and validate params
     CompletionGetSuggestionsParams params =
         new CompletionGetSuggestionsParams.fromRequest(request);
+    String filePath = params.file;
+    int offset = params.offset;
 
-    AnalysisResult result = await server.getAnalysisResult(params.file);
+    AnalysisResult result = await server.getAnalysisResult(filePath);
+    Source source;
 
     if (result == null || !result.exists) {
       if (server.onNoAnalysisCompletion != null) {
         String completionId = (_nextCompletionId++).toString();
         await server.onNoAnalysisCompletion(
             request, this, params, performance, completionId);
         return;
-      } else {
-        server.sendResponse(new Response.unknownSource(request));
+      }
+      source = server.resourceProvider.getFile(filePath).createSource();
+    } else {
+      if (offset < 0 || offset > result.content.length) {
+        server.sendResponse(new Response.invalidParameter(
+            request,
+            'params.offset',
+            'Expected offset between 0 and source length inclusive,'
+            ' but found ${offset}'));
         return;
       }
+      source =
+          server.resourceProvider.getFile(result.path).createSource(result.uri);
+
+      recordRequest(performance, source, result.content, offset);
     }
-
-    if (params.offset < 0 || params.offset > result.content.length) {
-      server.sendResponse(new Response.invalidParameter(
-          request,
-          'params.offset',
-          'Expected offset between 0 and source length inclusive,'
-          ' but found ${params.offset}'));
-      return;
-    }
-
-    Source source =
-        server.resourceProvider.getFile(result.path).createSource(result.uri);
-
-    recordRequest(performance, source, result.content, params.offset);
-
     CompletionRequestImpl completionRequest = new CompletionRequestImpl(
         result,
         server.resourceProvider,
         source,
-        params.offset,
+        offset,
         performance,
         server.ideOptions);
 
     String completionId = (_nextCompletionId++).toString();
 
     setNewRequest(completionRequest);
 
     // initial response without results
     server.sendResponse(new CompletionGetSuggestionsResult(completionId)
         .toResponse(request.id));
@@ skipping 79 matching lines @@
   final int replacementOffset;
 
   /**
    * The suggested completions.
    */
   final List<CompletionSuggestion> suggestions;
 
   CompletionResult(
       this.replacementOffset, this.replacementLength, this.suggestions);
 }