Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2910403003: Autofill username when the user interacts with the password field. (Closed)

Created:
3 years, 6 months ago by pkalinnikov
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Autofill username when the user interacts with the password field. Previously, when the user clicked on a password field, only this field was autocompleted with their password. This CL ensures that the username field is autocompleted as well. If the user interacts with a password field then the username is filled only if it was empty or *autofilled*, i.e. the user-supplied data is never overridden. Note that this works only if the username field was found. BUG=710374, 708605, 708602 Review-Url: https://codereview.chromium.org/2902113004 Cr-Original-Commit-Position: refs/heads/master@{#475329} Review-Url: https://codereview.chromium.org/2910403003 . Cr-Commit-Position: refs/branch-heads/3112@{#51} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/27a63fbaf769d23df0973c9d01ee9763ce3ca862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -207 lines) Patch
M chrome/renderer/autofill/password_autofill_agent_browsertest.cc View 11 chunks +240 lines, -202 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 4 chunks +20 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
pkalinnikov
3 years, 6 months ago (2017-05-31 13:46:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
27a63fbaf769d23df0973c9d01ee9763ce3ca862.

Powered by Google App Engine
This is Rietveld 408576698