Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2910393002:
[LayoutNG] Cleanup fixed TestExpectations in virtual/layout_ng (Closed)
Description[LayoutNG] Cleanup fixed TestExpectations in virtual/layout_ng
BUG=636993
TBR=eae@chromium.org, atotic@chromium.org, ikilpatrick@chromium.org
Review-Url: https://codereview.chromium.org/2910393002
Cr-Commit-Position: refs/heads/master@{#475851}
Committed: https://chromium.googlesource.com/chromium/src/+/ef77bad64ff86dda7f6390195285eae279d37e5e
Patch Set 1 #Patch Set 2 : Add Mac color failure #
Dependent Patchsets: Messages
Total messages: 21 (14 generated)
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== ngtests BUG= ========== to ========== [LayoutNG] Cleanup fixed TestExpectations in virtual/layout_ng BUG=636993 ==========
Description was changed from ========== [LayoutNG] Cleanup fixed TestExpectations in virtual/layout_ng BUG=636993 ========== to ========== [LayoutNG] Cleanup fixed TestExpectations in virtual/layout_ng BUG=636993 TBR=eae@chromium.org, atotic@chromium.org ==========
kojii@chromium.org changed reviewers: + atotic@chromium.org, eae@chromium.org
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [LayoutNG] Cleanup fixed TestExpectations in virtual/layout_ng BUG=636993 TBR=eae@chromium.org, atotic@chromium.org ========== to ========== [LayoutNG] Cleanup fixed TestExpectations in virtual/layout_ng BUG=636993 TBR=eae@chromium.org, atotic@chromium.org, ikilpatrick@chromium.org ==========
kojii@chromium.org changed reviewers: + ikilpatrick@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kojii@chromium.org
It looks like inline fixes fixed more than I thought, I was only checking CSS2/linebox.
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496221106398310,
"parent_rev": "e15b8a7a2ed4a844796968f23113955aa4403a7a", "commit_rev":
"ef77bad64ff86dda7f6390195285eae279d37e5e"}
Message was sent while issue was closed.
Description was changed from ========== [LayoutNG] Cleanup fixed TestExpectations in virtual/layout_ng BUG=636993 TBR=eae@chromium.org, atotic@chromium.org, ikilpatrick@chromium.org ========== to ========== [LayoutNG] Cleanup fixed TestExpectations in virtual/layout_ng BUG=636993 TBR=eae@chromium.org, atotic@chromium.org, ikilpatrick@chromium.org Review-Url: https://codereview.chromium.org/2910393002 Cr-Commit-Position: refs/heads/master@{#475851} Committed: https://chromium.googlesource.com/chromium/src/+/ef77bad64ff86dda7f6390195285... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ef77bad64ff86dda7f6390195285...
Message was sent while issue was closed.
On 2017/05/31 at 09:03:06, commit-bot wrote: > Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ef77bad64ff86dda7f6390195285... How did you generate this list? I just ran the test suite off master, and I pass additional 9 tests: virtual/layout_ng/external/wpt/css/CSS2/normal-flow/inline-non-replaced-height-002.xht virtual/layout_ng/external/wpt/css/CSS2/normal-flow/inline-non-replaced-height-003.xht virtual/layout_ng/external/wpt/css/CSS2/normal-flow/inline-replaced-width-001.xht virtual/layout_ng/external/wpt/css/CSS2/normal-flow/inline-replaced-width-002.xht virtual/layout_ng/external/wpt/css/CSS2/normal-flow/inline-replaced-width-003.xht virtual/layout_ng/external/wpt/css/CSS2/normal-flow/inline-replaced-width-006.xht virtual/layout_ng/fast/block/basic/003.html virtual/layout_ng/fast/block/basic/015.html virtual/layout_ng/fast/block/float/clamped-right-float.html
Message was sent while issue was closed.
On 2017/05/31 at 16:54:21, atotic wrote: > On 2017/05/31 at 09:03:06, commit-bot wrote: > > Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ef77bad64ff86dda7f6390195285... > > How did you generate this list? I just ran the test suite off master, and I pass additional 9 tests: Nope, I just ran tests locally on Linux, checked each unexpected pass to see if they really pass or magically passed, and removed. Please go ahead and remove more, maybe they were missed, or maybe flaky, I'm not sure, but if you remove and bots pass, I think we can remove them. If flaky, we can add them back.
Message was sent while issue was closed.
I'll update the tests with my Overflow patch. If test is flakey, it should be marked as such. For example: crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/normal-flow/block-in-inline-remove-002.xht [ Failure Pass ] TestExpectations should reflect what really happens. That way, we can track progress. On Wed, May 31, 2017 at 10:05 AM, <kojii@chromium.org> wrote: > On 2017/05/31 at 16:54:21, atotic wrote: >> On 2017/05/31 at 09:03:06, commit-bot wrote: >> > Committed patchset #2 (id:20001) as > https://chromium.googlesource.com/chromium/src/+/ef77bad64ff86dda7f6390195285... >> >> How did you generate this list? I just ran the test suite off master, and >> I > pass additional 9 tests: > > Nope, I just ran tests locally on Linux, checked each unexpected pass to see > if > they really pass or magically passed, and removed. > > Please go ahead and remove more, maybe they were missed, or maybe flaky, I'm > not > sure, but if you remove and bots pass, I think we can remove them. If flaky, > we > can add them back. > > https://codereview.chromium.org/2910393002/ -- You received this message because you are subscribed to the Google Groups "Blink Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
I'll update the tests with my Overflow patch. If test is flakey, it should be marked as such. For example: crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/normal-flow/block-in-inline-remove-002.xht [ Failure Pass ] TestExpectations should reflect what really happens. That way, we can track progress. On Wed, May 31, 2017 at 10:05 AM, <kojii@chromium.org> wrote: > On 2017/05/31 at 16:54:21, atotic wrote: >> On 2017/05/31 at 09:03:06, commit-bot wrote: >> > Committed patchset #2 (id:20001) as > https://chromium.googlesource.com/chromium/src/+/ef77bad64ff86dda7f6390195285... >> >> How did you generate this list? I just ran the test suite off master, and >> I > pass additional 9 tests: > > Nope, I just ran tests locally on Linux, checked each unexpected pass to see > if > they really pass or magically passed, and removed. > > Please go ahead and remove more, maybe they were missed, or maybe flaky, I'm > not > sure, but if you remove and bots pass, I think we can remove them. If flaky, > we > can add them back. > > https://codereview.chromium.org/2910393002/ -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
