DCHECK instead of return at LayoutSelection::Commit()

DCHECK instead of return at LayoutSelection::Commit()

We early return in some cases but they must not happen because
 we use valid VisibleSelection which is not null.

// We can get into a state where the selection endpoints map to the same	  
// |VisiblePosition| when a selection is deleted because we don't yet 
// the |FrameSelection| of text removal.
That's now not the case because we have SelectionController catching
 text modification.

BUG=708453
Review-Url: https://codereview.chromium.org/2910373002
Cr-Commit-Position: refs/heads/master@{#475870}
Committed: https://chromium.googlesource.com/chromium/src/+/57149441c70f2e87c1dc4e02895125536cb84baf

[yoichio, 2017-05-31 05:41:35]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 05:41:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2017-05-31 07:05:34]

Description was changed from

==========
Dcheck instead of return in LayoutSelection::Commit()

BUG=708453
==========

to

==========
DCHECK instead of return at LayoutSelection::Commit()

We early return in some cases but they must not happen because
 we use valid VisibleSelection which is not null.

// We can get into a state where the selection endpoints map to the same	  
// |VisiblePosition| when a selection is deleted because we don't yet 
// the |FrameSelection| of text removal.
That's now not the case because we have SelectionController catching
 text modification.

BUG=708453
==========

[yoichio, 2017-05-31 07:05:34]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[yosin_UTC9, 2017-05-31 07:20:09]

lgtm

[commit-bot: I haz the power, 2017-05-31 07:46:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 07:46:46]

Dry run: This issue passed the CQ dry run.

[yoichio, 2017-05-31 10:38:01]

The CQ bit was checked by yoichio@chromium.org

[commit-bot: I haz the power, 2017-05-31 10:38:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 10:42:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496227081841410, "parent_rev":
"39b0c40647373a6f357369e81e316383a7fad397", "commit_rev":
"57149441c70f2e87c1dc4e02895125536cb84baf"}

[commit-bot: I haz the power, 2017-05-31 10:42:30]

Description was changed from

==========
DCHECK instead of return at LayoutSelection::Commit()

We early return in some cases but they must not happen because
 we use valid VisibleSelection which is not null.

// We can get into a state where the selection endpoints map to the same	  
// |VisiblePosition| when a selection is deleted because we don't yet 
// the |FrameSelection| of text removal.
That's now not the case because we have SelectionController catching
 text modification.

BUG=708453
==========

to

==========
DCHECK instead of return at LayoutSelection::Commit()

We early return in some cases but they must not happen because
 we use valid VisibleSelection which is not null.

// We can get into a state where the selection endpoints map to the same	  
// |VisiblePosition| when a selection is deleted because we don't yet 
// the |FrameSelection| of text removal.
That's now not the case because we have SelectionController catching
 text modification.

BUG=708453

Review-Url: https://codereview.chromium.org/2910373002
Cr-Commit-Position: refs/heads/master@{#475870}
Committed:
https://chromium.googlesource.com/chromium/src/+/57149441c70f2e87c1dc4e028951...
==========

[commit-bot: I haz the power, 2017-05-31 10:42:31]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/57149441c70f2e87c1dc4e028951...