Issue 291033002: [Telemetry] Make page navigations synchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 291033002: [Telemetry] Make page navigations synchronous. (Closed)

Created:
6 years, 7 months ago by tonyg

Modified:
6 years, 7 months ago

Reviewers:
achuithb, dtu, nduca

CC:
chromium-reviews, telemetry+watch_chromium.org, Peter Kasting

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Telemetry] Make page navigations synchronous. This fixes a race where a stray Page.frameNavigated might be considered to be a completion of the requested navigation. Unfortunately, I don't know how to trigger this race in a unittest. BUG=367306 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271655

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -7 lines)			Patch
	M	tools/telemetry/telemetry/core/backends/chrome/inspector_page.py	View		1 chunk	+1 line, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/291033002/20001

6 years, 7 months ago (2014-05-20 06:53:23 UTC) #4

Message was sent while issue was closed.

Change committed as 271655

Expand Messages | Collapse Messages