Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1463)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/inspector_page.py

Issue 291033002: [Telemetry] Make page navigations synchronous. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/backends/chrome/inspector_page.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/inspector_page.py b/tools/telemetry/telemetry/core/backends/chrome/inspector_page.py
index 2874268caef4c93e983778c32cacaf0b098c164b..cd3a529de97a5d412437c7ac6693e5694373ffcf 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/inspector_page.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/inspector_page.py
@@ -101,19 +101,13 @@ class InspectorPage(object):
def DoNavigate():
self._SetScriptToEvaluateOnCommit(script_to_evaluate_on_commit)
- # Navigate the page. However, there seems to be a bug in chrome devtools
- # protocol where the request id for this event gets held on the browser
- # side pretty much indefinitely.
- #
- # So, instead of waiting for the event to actually complete, wait for the
- # Page.frameNavigated event.
request = {
'method': 'Page.navigate',
'params': {
'url': url,
}
}
- self._inspector_backend.SendAndIgnoreResponse(request)
+ self._inspector_backend.SyncRequest(request, timeout)
self._navigation_url = url
self.PerformActionAndWaitForNavigate(DoNavigate, timeout)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698