Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2910323002:
Remove old code in chrome/browser/platform_util_win.cc. (Closed)
DescriptionRemove old code in chrome/browser/platform_util_win.cc.
Some of this code is designed to run on pre-Vista Windows, but modern
Chromium requires at least Windows 7.
Review-Url: https://codereview.chromium.org/2910323002
Cr-Commit-Position: refs/heads/master@{#476079}
Committed: https://chromium.googlesource.com/chromium/src/+/0eb9a6df95a925995a1021cf290f4d08b5b03fcd
Patch Set 1 #Patch Set 2 : build #Patch Set 3 : resolve merge conflicts #Patch Set 4 : Old code used NULL when it meant 0 #Messages
Total messages: 21 (17 generated)
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thestig@chromium.org changed reviewers: + stanisc@chromium.org
This obviously conflicts with your CL. Will wait for yours to land first.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
lgtm
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thestig@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from stanisc@chromium.org Link to the patchset: https://codereview.chromium.org/2910323002/#ps60001 (title: "Old code used NULL when it meant 0")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496271666176560,
"parent_rev": "3e3b397f8f49f4fc83c3f14593567eb9ea70e032", "commit_rev":
"0eb9a6df95a925995a1021cf290f4d08b5b03fcd"}
Message was sent while issue was closed.
Description was changed from ========== Remove old code in chrome/browser/platform_util_win.cc. Some of this code is designed to run on pre-Vista Windows, but modern Chromium requires at least Windows 7. ========== to ========== Remove old code in chrome/browser/platform_util_win.cc. Some of this code is designed to run on pre-Vista Windows, but modern Chromium requires at least Windows 7. Review-Url: https://codereview.chromium.org/2910323002 Cr-Commit-Position: refs/heads/master@{#476079} Committed: https://chromium.googlesource.com/chromium/src/+/0eb9a6df95a925995a1021cf290f... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/0eb9a6df95a925995a1021cf290f... |
