tools/metrics/histograms/histograms.xml - Issue 2910313002: [Android WebAPK] Add UMA histogram to record error code when install fails pt 2/3

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2910313002: [Android WebAPK] Add UMA histogram to record error code when install fails pt 2/3 (Closed)

Patch Set: Merge branch 'master' into more_uma Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 24af86dd00789a905d65e918fcb1ff61bce24c61..1430742323495c7f731e2e9f006086a40daa6429 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -81159,6 +81159,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="WebApk.Install.GooglePlayInstallErrorCode" units="code">

Ilya Sherman 2017/06/08 01:29:00 Would it make sense to instead specify an enum her

pkotwicz 2017/06/08 02:23:21 - The error codes are defined in the internal code

Ilya Sherman 2017/06/08 02:27:37 Okay. Could you please add this com.google pointe

+ <owner>hanxi@chromium.org</owner>

+ <owner>pkotwicz@chromium.org</owner>

+ <owner>yfriedman@chromium.org</owner>

+ <summary>

+ Records the error code when installing a WebAPK from Google Play fails.

Ilya Sherman 2017/06/08 01:29:00 Do you also record success when the installation s

pkotwicz 2017/06/08 02:23:21 The WebApk.Install.GooglePlayInstallResult histogr

+ </summary>

+</histogram>

<histogram name="WebApk.Install.GooglePlayInstallResult"

enum="WebApkGooglePlayInstallResult">

<owner>hanxi@chromium.org</owner>