Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/GooglePlayWebApkInstallDelegate.java

Issue 2910313002: [Android WebAPK] Add UMA histogram to record error code when install fails pt 2/3 (Closed)
Patch Set: Merge branch 'master' into more_uma Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/GooglePlayWebApkInstallDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/GooglePlayWebApkInstallDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/GooglePlayWebApkInstallDelegate.java
index 7de2c2403bec3982e00e2728941270eaa7f9ccf9..c19430a28dc338745e67e537b8b6da5e16959b7b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/GooglePlayWebApkInstallDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/GooglePlayWebApkInstallDelegate.java
@@ -4,33 +4,12 @@
package org.chromium.chrome.browser.webapps;
-import android.support.annotation.IntDef;
-
import org.chromium.base.Callback;
-import java.lang.annotation.Retention;
-import java.lang.annotation.RetentionPolicy;
-
/**
* Defines an interface for installing WebAPKs via Google Play.
*/
public interface GooglePlayWebApkInstallDelegate {
- /**
- * The app state transitions provided by Google Play during download and installation process.
- */
- @Retention(RetentionPolicy.SOURCE)
- @IntDef({INVALID, DOWNLOAD_PENDING, DOWNLOADING, DOWNLOAD_CANCELLED, DOWNLOAD_ERROR,
- INSTALLING, INSTALL_ERROR, INSTALLED})
- public @interface InstallerPackageEvent {}
- public static final int INVALID = -1;
- public static final int DOWNLOAD_PENDING = 0;
- public static final int DOWNLOADING = 1;
- public static final int DOWNLOAD_CANCELLED = 2;
- public static final int DOWNLOAD_ERROR = 3;
- public static final int INSTALLING = 4;
- public static final int INSTALL_ERROR = 5;
- public static final int INSTALLED = 6;
-
/**
* Uses Google Play to install WebAPK asynchronously.
* @param packageName The package name of WebAPK to install.
@@ -54,10 +33,4 @@ public interface GooglePlayWebApkInstallDelegate {
*/
void updateAsync(String packageName, int version, String title, String token, String url,
Callback<Integer> callback);
- /**
- * Calls the callback once the installation either succeeded or failed.
- * @param packageName The package name of WebAPK for the installation.
- * @param event The result of the install.
- */
- void onGotInstallEvent(String packageName, @InstallerPackageEvent int event);
}

Powered by Google App Engine
This is Rietveld 408576698