Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2910243002: Update a WebAPK string. (Closed)

Created:
3 years, 6 months ago by Xi Han
Modified:
3 years, 6 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, hiroshige+script_chromium.org, zpeng+watch_chromium.org, kouhei+script_chromium.org, kochi+script_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update a WebAPK string. Review-Url: https://codereview.chromium.org/2910243002 Cr-Commit-Position: refs/heads/master@{#475758} Committed: https://chromium.googlesource.com/chromium/src/+/8ed6b9f070965add12632e7783ddaebbbd63c594

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/webapk/strings/android_webapk_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Xi Han
Since these strings will be translated soon, I would like to correct it early. Could ...
3 years, 6 months ago (2017-05-30 17:07:42 UTC) #2
pkotwicz
lgtm
3 years, 6 months ago (2017-05-31 00:08:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910243002/1
3 years, 6 months ago (2017-05-31 00:09:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8ed6b9f070965add12632e7783ddaebbbd63c594
3 years, 6 months ago (2017-05-31 02:54:45 UTC) #8
Xi Han
3 years, 6 months ago (2017-05-31 14:59:42 UTC) #9
Message was sent while issue was closed.
Thank you Peter!

Powered by Google App Engine
This is Rietveld 408576698