Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.h

Issue 2910233002: Do not fallback to FocusedOrMainFrame() in FocusedLocalFrameInWidget() (Closed)
Patch Set: Fixed a crashing test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.h
diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.h b/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
index 326e9182b778b32c03db3677bcad9956158ffd06..028535e081525b21d25e8189191bb777b616b8d6 100644
--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
@@ -181,14 +181,6 @@ class WebFrameWidgetImpl final
WebInputEventResult HandleKeyEvent(const WebKeyboardEvent&) override;
WebInputEventResult HandleCharEvent(const WebKeyboardEvent&) override;
- // This method returns the focused frame belonging to this WebWidget, that
- // is, a focused frame with the same local root as the one corresponding
- // to this widget. It will return nullptr if no frame is focused or, the
- // focused frame has a different local root.
- LocalFrame* FocusedLocalFrameInWidget() const;
-
- LocalFrame* FocusedLocalFrameAvailableForIme() const;
-
CompositorMutatorImpl& Mutator();
WebWidgetClient* client_;
@@ -223,11 +215,6 @@ class WebFrameWidgetImpl final
bool base_background_color_override_enabled_;
WebColor base_background_color_override_;
- // TODO(ekaramad): Can we remove this and make sure IME events are not called
- // when there is no page focus?
- // Represents whether or not this object should process incoming IME events.
- bool ime_accept_events_;
-
static const WebInputEvent* current_input_event_;
WebColor base_background_color_;

Powered by Google App Engine
This is Rietveld 408576698