third_party/WebKit/Source/web/tests/WebViewTest.cpp - Issue 2910233002: Do not fallback to FocusedOrMainFrame() in FocusedLocalFrameInWidget()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2910233002: Do not fallback to FocusedOrMainFrame() in FocusedLocalFrameInWidget() (Closed)

Patch Set: Fixed a crashing test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

index 7f4f3c7952fd4af5ca71aa39109c91397a17e89f..80601d5c161fbedeb98befaa45f1813fffecc50e 100644

--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

@@ -2324,6 +2324,7 @@ TEST_P(WebViewTest, FinishComposingTextDoesNotDismissHandles) {

base_url_ + "longpress_selection.html", true);

web_view->Resize(WebSize(500, 300));

web_view->UpdateAllLifecyclePhases();

+ web_view->SetInitialFocus(false);

EhsanK 2017/05/30 22:39:22 Without it line 2332 returns nullptr after the cha

RunPendingTasks();

WebString target = WebString::FromUTF8("target");