Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 2910203002: [api] Add an API function to set the GetExternallyAllocatedMemoryInBytesCallback. (Closed)

Created:
3 years, 6 months ago by Hannes Payer (out of office)
Modified:
3 years, 6 months ago
CC:
Hannes Payer (out of office), v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Add an API function to set the GetExternallyAllocatedMemoryInBytesCallback. BUG=chromium:727569 Review-Url: https://codereview.chromium.org/2910203002 Cr-Commit-Position: refs/heads/master@{#45599} Committed: https://chromium.googlesource.com/v8/v8/+/f314b3cdb9766eb1ba6efe1243ac89b3d0295f63

Patch Set 1 #

Patch Set 2 : [api] Add an API function to set the GetExternallyAllocatedMemoryInBytesCallback. #

Patch Set 3 : printf use #

Patch Set 4 : comment #

Total comments: 2

Patch Set 5 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M include/v8.h View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/heap/heap.h View 3 chunks +14 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
jochen (gone - plz use gerrit)
lgtm
3 years, 6 months ago (2017-05-30 12:43:07 UTC) #2
Michael Lippautz
LGTM https://codereview.chromium.org/2910203002/diff/60001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/2910203002/diff/60001/include/v8.h#newcode7154 include/v8.h:7154: * externally of the V8 heap. Ideally this ...
3 years, 6 months ago (2017-05-30 12:45:10 UTC) #5
Hannes Payer (out of office)
https://codereview.chromium.org/2910203002/diff/60001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/2910203002/diff/60001/include/v8.h#newcode7154 include/v8.h:7154: * externally of the V8 heap. Ideally this memory ...
3 years, 6 months ago (2017-05-30 12:47:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910203002/80001
3 years, 6 months ago (2017-05-30 12:47:28 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 13:18:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/f314b3cdb9766eb1ba6efe1243ac89b3d02...

Powered by Google App Engine
This is Rietveld 408576698