Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2910173003: Revert of Making answer card to behave like other results. (Closed)

Created:
3 years, 6 months ago by tyoshino (SeeGerritForStatus)
Modified:
3 years, 6 months ago
Reviewers:
xiyuan, jam, vadimt, sky
CC:
chromium-reviews, tfarina, Matt Giuca
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Making answer card to behave like other results. (patchset #6 id:100001 of https://codereview.chromium.org/2905523004/ ) Reason for revert: This broke a build https://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20x86-generic%20Compile/builds/36279 Original issue's description: > Making answer card to behave like other results. > > Now it lives in a search result container, which can be selected, > highlighted, navigated with keyboard etc. > > Opening the result (i.e. what happens upon clicking on it) is not yet > implemented. > > Unit test for the new result container isn't yet implemented since both > result opening and accessibility behavior are not yet implemented. > > Bug=712331 > > Review-Url: https://codereview.chromium.org/2905523004 > Cr-Commit-Position: refs/heads/master@{#475782} > Committed: https://chromium.googlesource.com/chromium/src/+/2420a92712ee82be175bea6750774bec8006c5ce TBR=xiyuan@chromium.org,jam@chromium.org,sky@chromium.org,vadimt@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug=712331 Review-Url: https://codereview.chromium.org/2910173003 Cr-Commit-Position: refs/heads/master@{#475795} Committed: https://chromium.googlesource.com/chromium/src/+/c7fa269d3f2ded36cadedb9c9e33ba725c9b044b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -329 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/ui/web_contents_set_background_color.h View 1 chunk +44 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/ui/web_contents_set_background_color.cc View 1 chunk +57 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search_answer_web_contents_delegate.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M ui/app_list/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/app_list/views/contents_view.h View 4 chunks +10 lines, -1 line 0 comments Download
M ui/app_list/views/contents_view.cc View 6 chunks +54 lines, -9 lines 0 comments Download
D ui/app_list/views/search_result_answer_card_view.h View 1 chunk +0 lines, -57 lines 0 comments Download
D ui/app_list/views/search_result_answer_card_view.cc View 1 chunk +0 lines, -144 lines 0 comments Download
M ui/app_list/views/search_result_container_view.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/controls/webview/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/views/controls/webview/web_contents_set_background_color.h View 1 chunk +0 lines, -46 lines 0 comments Download
D ui/views/controls/webview/web_contents_set_background_color.cc View 1 chunk +0 lines, -57 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
tyoshino (SeeGerritForStatus)
Created Revert of Making answer card to behave like other results.
3 years, 6 months ago (2017-05-31 04:20:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910173003/1
3 years, 6 months ago (2017-05-31 04:20:51 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 04:21:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c7fa269d3f2ded36cadedb9c9e33...

Powered by Google App Engine
This is Rietveld 408576698