Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issue 291013003: Revert 271468 "Revert of [Refactor] Consolidate the logic for wh..." (Closed)

Created:
6 years, 7 months ago by Elliot Glaysher
Modified:
6 years, 7 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 271468 "Revert of [Refactor] Consolidate the logic for wh..." The revert broke Windows interactive_ui_tests. The world has probably changed since this was first committed. WidgetTestInteractive.CanActivateFlagIsHonored http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/29193/steps/interactive_ui_tests/logs/stdio > Revert of [Refactor] Consolidate the logic for whether a widget can be activated. (https://codereview.chromium.org/286733002/) > > Reason for revert: > This CL was causing problems when the value of views::Widget::CanActivate() changes crbug.com/374095 > > I also need to audit the code to find out whether there are any 'non-activatable' widgets which were intended to be activatable > > Original issue's description: > > [Refactor] Consolidate the logic for whether a widget can be activated. > > > > This is a first step towards giving tooltips their own WindowTreeHosts on Linux. > > > > BUG=353533 > > TEST=None > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270597 > > Review URL: https://codereview.chromium.org/297503003 TBR=pkotwicz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271511

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -61 lines) Patch
M trunk/src/ash/accelerators/exit_warning_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ash/display/shared_display_edge_indicator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ash/magnifier/partial_magnification_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/shelf/shelf_widget.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/sticky_keys/sticky_keys_overlay.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ash/tooltips/tooltip_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ash/touch/touch_observer_hud.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/wm/dock/docked_window_layout_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ash/wm/drag_window_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ash/wm/gestures/long_press_affordance_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/wm/maximize_mode/workspace_backdrop_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/wm/overview/scoped_window_copy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ash/wm/overview/window_selector_item.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ash/wm/overview/window_selector_window.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ash/wm/panels/panel_layout_manager.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/ash/wm/workspace/multi_window_resize_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ash/wm/workspace/phantom_window_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/ui/idle_app_name_notification_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/first_run/try_chrome_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/views/fullscreen_exit_bubble_views.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/views/screen_capture_notification_ui_views.cc View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/mojo/examples/launcher/launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/views/bubble/bubble_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/ui/views/touchui/touch_selection_controller_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M trunk/src/ui/views/widget/native_widget_aura.h View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/ui/views/widget/native_widget_aura.cc View 5 chunks +3 lines, -7 lines 0 comments Download
M trunk/src/ui/views/widget/native_widget_aura_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/ui/views/widget/widget.h View 3 chunks +12 lines, -1 line 0 comments Download
M trunk/src/ui/views/widget/widget.cc View 6 chunks +20 lines, -9 lines 0 comments Download
M trunk/src/ui/views/widget/widget_hwnd_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/ui/views/widget/widget_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/views/widget/widget_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
6 years, 7 months ago (2014-05-19 22:57:21 UTC) #1
Elliot Glaysher
6 years, 7 months ago (2014-05-19 22:59:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r271511 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698