Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 297503003: Revert: [Refactor] Consolidate the logic for whether a widget can be activated. This is a first ste (Closed)

Created:
6 years, 7 months ago by pkotwicz
Modified:
6 years, 7 months ago
Reviewers:
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, alicet1, ben+mojo_chromium.org, qsr+mojo_chromium.org, tdanderson+views_chromium.org, msw+watch_chromium.org, stevenjb+watch_chromium.org, abarth-chromium, kalyank, tdanderson+overview_chromium.org, dcheng, oshima+watch_chromium.org, ben+views_chromium.org, tfarina, Aaron Boodman, ben+ash_chromium.org, darin (slow to review), James Su, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert of [Refactor] Consolidate the logic for whether a widget can be activated. (https://codereview.chromium.org/286733002/) Reason for revert: This CL was causing problems when the value of views::Widget::CanActivate() changes crbug.com/374095 I also need to audit the code to find out whether there are any 'non-activatable' widgets which were intended to be activatable Original issue's description: > [Refactor] Consolidate the logic for whether a widget can be activated. > > This is a first step towards giving tooltips their own WindowTreeHosts on Linux. > > BUG=353533 > TEST=None > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270597 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -55 lines) Patch
M ash/accelerators/exit_warning_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/display/shared_display_edge_indicator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/magnifier/partial_magnification_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_widget.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/sticky_keys/sticky_keys_overlay.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/tooltips/tooltip_controller_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/touch/touch_observer_hud.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_layout_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/drag_window_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/gestures/long_press_affordance_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/workspace_backdrop_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/scoped_window_copy.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/overview/window_selector_item.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/overview/window_selector_window.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/panels/panel_layout_manager.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/workspace/phantom_window_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/ui/idle_app_name_notification_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/first_run/try_chrome_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/fullscreen_exit_bubble_views.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/screen_capture_notification_ui_views.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/examples/launcher/launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/bubble/bubble_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 5 chunks +7 lines, -3 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/widget/widget.h View 3 chunks +1 line, -12 lines 0 comments Download
M ui/views/widget/widget.cc View 6 chunks +9 lines, -20 lines 0 comments Download
M ui/views/widget/widget_hwnd_utils.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
pkotwicz
6 years, 7 months ago (2014-05-19 20:40:39 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r271468.

Powered by Google App Engine
This is Rietveld 408576698