Remove deprecated base::NonThreadSafe in media/cast.

Remove deprecated base::NonThreadSafe in media/cast.

Note to crash team: This CL is a refactor and has no intended behavior change.

It was not replaced by SequenceChecker per request from OWNERS.

BUG=676387
This CL was uploaded by git cl split.

R=miu@chromium.org

Review-Url: https://codereview.chromium.org/2910063002
Cr-Commit-Position: refs/heads/master@{#476035}
Committed: https://chromium.googlesource.com/chromium/src/+/c4686a2a8cd62dceec3336a2b06c721d02daf140

[gab, 2017-05-30 02:36:21]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2017-05-30 02:36:24]

Hi, this is an automated change made by https://crbug.com/676387#c8 and sharded
across directories for OWNERS.

No human has looked at this specific output yet, see cl description for things
to watch for.

If it LGTY, please CQ.

If it didn't pass CQ dry-run it may be a simple patch failure or an IWYU failure
from having this being a partial CL... please review anyways and a human will
look at the failure (and ping for re-review if anything major is required..). It
is known to compile all targets on Windows at r474679...  manual tweaks will
likely be required to smoothen things off, bear with me!

Thanks!
Gab

[commit-bot: I haz the power, 2017-05-30 02:36:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 04:27:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 04:27:32]

Dry run: This issue passed the CQ dry run.

[miu, 2017-05-31 02:53:19]

gab: Nothing wrong with your script, but it did show us that the use of
base::NotThreadSafe was misguided in these files. I would be perfectly fine with
removing base::NotThreadSafe and then NOT adding any of the
base::SequenceChecker stuff. Meaning: There's no reason to restrict which thread
calls the dtor of these classes, so long as the dtor is called at a time these
objects are not being used/referenced elsewhere.

[gab, 2017-05-31 16:43:56]

Description was changed from

==========
Replace deprecated base::NonThreadSafe in media/cast in favor of
SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=miu@chromium.org
==========

to

==========
Remove deprecated base::NonThreadSafe in media/cast.

Note to crash team: This CL is a refactor and has no intended behavior change.

It was not replaced by SequenceChecker per request from OWNERS.

BUG=676387
This CL was uploaded by git cl split.

R=miu@chromium.org
==========

[gab, 2017-05-31 16:44:01]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2017-05-31 16:44:18]

On 2017/05/31 02:53:19, miu wrote:
> gab: Nothing wrong with your script, but it did show us that the use of
> base::NotThreadSafe was misguided in these files. I would be perfectly fine
with
> removing base::NotThreadSafe and then NOT adding any of the
> base::SequenceChecker stuff. Meaning: There's no reason to restrict which
thread
> calls the dtor of these classes, so long as the dtor is called at a time these
> objects are not being used/referenced elsewhere.

Done, please CQ if LGTYs. Thanks!

[commit-bot: I haz the power, 2017-05-31 16:44:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 18:37:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 18:37:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gab, 2017-05-31 18:58:24]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 18:59:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 21:20:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 21:20:43]

Dry run: This issue passed the CQ dry run.

[miu, 2017-05-31 21:27:52]

The CQ bit was checked by miu@chromium.org

[miu, 2017-05-31 21:27:53]

lgtm

[commit-bot: I haz the power, 2017-05-31 21:28:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 21:35:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496266072270740,
"parent_rev": "77b98c4aea6f046286c70ea05a083002ac7db519", "commit_rev":
"c4686a2a8cd62dceec3336a2b06c721d02daf140"}

[commit-bot: I haz the power, 2017-05-31 21:35:17]

Description was changed from

==========
Remove deprecated base::NonThreadSafe in media/cast.

Note to crash team: This CL is a refactor and has no intended behavior change.

It was not replaced by SequenceChecker per request from OWNERS.

BUG=676387
This CL was uploaded by git cl split.

R=miu@chromium.org
==========

to

==========
Remove deprecated base::NonThreadSafe in media/cast.

Note to crash team: This CL is a refactor and has no intended behavior change.

It was not replaced by SequenceChecker per request from OWNERS.

BUG=676387
This CL was uploaded by git cl split.

R=miu@chromium.org

Review-Url: https://codereview.chromium.org/2910063002
Cr-Commit-Position: refs/heads/master@{#476035}
Committed:
https://chromium.googlesource.com/chromium/src/+/c4686a2a8cd62dceec3336a2b06c...
==========

[commit-bot: I haz the power, 2017-05-31 21:35:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c4686a2a8cd62dceec3336a2b06c...